Begin by creating a lowest-level triple of the types needed to
implement a token bucket: a configuration, a timestamp, and the raw
bucket itself.

Note that for low-level buckets, the units of the timestamp and the
bucket itself are unspecified: each user can use a different type.

(This patch breaks check-spaces; a later patch will fix it)

This is a simple search-and-replace to rename the token bucket type
to indicate that it contains both a read and a write bucket, bundled
with their configuration.  It's preliminary to refactoring the
bucket type.

See bug #25787 for discussion; we should have a better fix here.

This differs from our previous token bucket abstraction in a few
ways:

  1) It is an abstraction, and not a collection of fields.
  2) It is meant to be used with monotonic timestamps, which should
     produce better results than calling gettimeofday over and over.

(It turns out we can't just expose STAMP_TICKS_PER_SECOND, since
Apple doesn't have that.)

This function was only used by PortForwardingHelper, which was
removed in 9df110cd.  Its presence caused warnings on windows.

When size_t is 32 bits, the unit tests can't fit anything more than
4GB-1 into a size_t.

Additionally, tt_int_op() uses "long" -- we need tt_u64_op() to
safely test uint64_t values for equality.

Bug caused by tests for #24782 fix; not in any released Tor.

When size_t is 32 bits, doing "size_t ram; if (ram > 8GB) { ... }"
produces a compile-time warning.

Bug caused by #24782 fix; not in any released Tor.

Alexander Hansen Færøy authored 6 years ago and Nick Mathewson committed 6 years ago

This patch changes the algorithm of compute_real_max_mem_in_queues() to
use 0.4 * RAM iff the system has more than or equal to 8 GB of RAM, but
will continue to use the old value of 0.75 * RAM if the system have less
than * GB of RAM available.

This patch also adds tests for compute_real_max_mem_in_queues().

See: https://bugs.torproject.org/24782

Alexander Hansen Færøy authored 6 years ago and David Goulet committed 6 years ago

This patch makes compute_real_max_mem_in_queues use the STATIC macro,
which allows us to test the function.

See: https://bugs.torproject.org/24782

Alexander Hansen Færøy authored 6 years ago and David Goulet committed 6 years ago

This patch makes get_total_system_memory mockable, which allows us to
alter the return value of the function in tests.

See: https://bugs.torproject.org/24782

The old single-underscore names remain as a deprecated synonym.

Fixes bug 25581; bugfix on 0.3.3.1-alpha.

Mike Perry authored 7 years ago and Nick Mathewson committed 6 years ago

We removed this by breaking them out from general in #13837.

 * FIXES part of #25409: https://bugs.torproject.org/25409

This option was used for shadow testing previously, but is no longer
used for anything.  It interferes with refactoring our token buckets.