Andreas Stieger authored 7 years ago and Nick Mathewson committed 7 years ago

Add magic comments recognized by default -Wimplicit-fallthrough=3
or break, as required.

we should have taken out this comment with commit aadff627
during ticket 16480.

Fixes bug #22424 on 0.3.1.1-alpha.

No behaviour change.

Part of #22424.

Part of #22424.

Part of #22424.

This brings the description up to date with the exponential backoff
code introduced in 0.2.9.1-alpha.

Fixes bug #22421.

Fixes crash when including a folder that contains a non-empty file
without any values followed by any other non-empty file.

A fair number of our mock_impl declarations were messed up so that
even our special AM_ETAGSFLAGS couldn't find them.

This should be a whitespace-only patch.

(Note that a lot of the removed guidance is stuff that the tools
will do automatically.)

teor authored 7 years ago and Roger Dingledine committed 7 years ago

When directory authorities reject a router descriptor due to keypinning,
free the router descriptor rather than leaking the memory.

Fixes bug 22370; bugfix on 0.2.7.2-alpha.

If we add the element itself, we will later free it when we free the
descriptor, and the next time we go to look at MyFamily, things will
go badly.

Fixes the rest of bug 22368; bugfix on 0.3.1.1-alpha.

If we free them here, we will still attempt to access the freed memory
later on, and also we will double-free when we are freeing the config.

Fixes part of bug 22368.

It's still not great, but should be less confusing what's wrong
here.

Closes ticket 1121.

in retrospect, we should have removed this with commit 1289474d
as part of #11742, which was the last caller of it.

No code changes needed: in the places where we actually check the
return value of these functions, we handle it correctly.

See: https://bugs.torproject.org/22305