PLURAL() assumes that the plural is the canonical name for the option,
so now it is.

These were found by looking for tor_snprintf() instances that were
preceeded closely by tor_malloc(), though I probably converted some
more snprintfs as well.

(In every case, make sure that the length variable (if any) is
removed, renamed, or lowered, so that anything else that might have
assumed a longer buffer doesn't exist.)

These were found by looking for tor_snprintf() instances that were
followed closely by tor_strdup(), though I probably converted some
other snprintfs as well.

(To ensure correctness, in every case, make sure that the temporary
variable is deleted, renamed, or lowered in scope, so we can't have
any bugs related to accidentally relying on the no-longer-filled
variable.)

resolves ticket 3946

Implements ticket #4207

Fixes bug #4897, not yet in any release.

Using n_circ_id alone here (and below, when n_conn is NULL) really sucks,
but that's a separate bug which will need a changes/ file.

This fixes bug 3325, where a bad .exit would get logged as a bad .onion

fixes 4837

Apparently I missed a case when converting sec,usec to
yyyy-mm-ddThh:mm:ss.uuuuuu .

Conflicts:
	src/or/rendclient.c

This needs a changes file and more testing.

Also give the arguments to control_event_circuit_status_minor real
names.

Robert Ransom authored 13 years ago and Nick Mathewson committed 13 years ago

A fixup commit which was intended to make this formula easier to read
broke it instead.