This should make it more clear what I meant, if you know how to read ABNF.

(Thanks to rl1987 for correcting numerous issues here)

cypherpunks authored 9 years ago and Nick Mathewson committed 9 years ago

The workqueue test help message has two issues. First, the message uses 4 space
indentation when 2 space indentation seems more common. Second, the help
message misses some options.

This commit fixes both issues.

Closes ticket 2325

closes 16162.

1) We already require C99.

2) This allows us to support MSVC again (thanks to Gisle Vanem for
   this part)

3) This change allows us to dump some rotten old compatibility code
   from log.c

We haven't implemented NO_REPAIR for NEEDCERT, and we don't need it:
but it's safest to stop any attempt to use it that way.

Teor found these.  This is for part of #16582.

This is a brute-force fix for #16580, wherein #16530 caused some
routers to do bad things with the old keypinning journal.

Make sure that signing certs are signed by the right identity key,
to prevent a recurrence of #16530.  Also make sure that the master
identity key we find on disk matches the one we have in RAM, if we
have one.

This is for #16581.

When there is a signing key and the certificate lists a key, make
sure that the certificate lists the same signing key.

When there are public key and secret key stored in separate files,
make sure they match.

Use the right file name when we load an encrypted secret key and
then find a problem with it.

This is part of 16581.

This implements feature 16582: if we get EMFILE or something when
loading our master key, we should not at that point attempt to
overwrite it.

This is an important part of #16582.

Task #15824