Fixes bug 7727; fix on 0.2.4.10-alpha.

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

I think we want both sets of messages to appear independently to help us know
what needs tuning.

Right now, all our curve25519 backends ignore the high bit of the
public key. But possibly, others could treat the high bit of the
public key as encoding out-of-bounds values, or as something to be
preserved. This could be used to distinguish clients with different
backends, at the cost of killing a circuit.

As a workaround, let's just clear the high bit of each public key
indiscriminately before we use it. Fix for bug 8121, reported by
rransom. Bugfix on 0.2.4.8-alpha.

I noticed bad wifi networks can have low use success rates.

Implements ticket 8151.

Authorities don't set is_possible_guard on node_t, so they were
never deciding that they could build enough paths.  This is a quick
and dirty fix.

Bug not in any released version of Tor

These seem to have gotten conflicted out of existence while mike was
working on path bias stuff.

Thanks to sysrqb for collecting these in a handy patch.

It appears that the code for 7291 gave an unused-value warning when
built with --disable-curve25519.

The fix is to move the two functions to format/parse base64
curve25519 public keys into a new "crypto_format.c" file.  I could
have put them in crypto.c, but that's a big file worth splitting
anyway.

Fixes bug 8153; bugfix on 0.2.4.8-alpha where I did the fix for 7869.

This prevents bug 8147, where such nodes would accrue points towards
Guard, Fast, HSDir, and so on.

Fixes bug 8147.

Another bug 8145 fix.

Fix for 8145.

Fixes bug 8146.

When we first implemented TLS, we assumed in conneciton_handle_write
that a TOR_TLS_WANT_WRITE from flush_buf_tls meant that nothing had
been written. But when we moved our buffers to a ring buffer
implementation back in 0.1.0.5-rc (!), we broke that invariant: it's
possible that some bytes have been written but nothing.

That's bad.  It means that if we do a sequence of TLS writes that ends
with a WANTWRITE, we don't notice that we flushed any bytes, and we
don't (I think) decrement buckets.

Fixes bug 7708; bugfix on 0.1.0.5-rc

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

This informational counter is probably now redundant, but might as well keep
it consistent I guess.

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

It had nothing to do with circuit build times.

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

The other remaining parameters don't really need range checks.

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

Also document it better.

Mention this refactoring in the comments for the path state machine.

Mike Perry authored 12 years ago and Nick Mathewson committed 12 years ago

Also, deprecate the torrc options for the scaling values. It's unlikely anyone
but developers will ever tweak them, even if we provided a single ratio value.

Improve the log message when "Bug/attack: unexpected sendme cell
from client" occurs.

This is the non-automated portion of bug 7599.

This is meant to avoid conflict with the built-in log() function in
math.h.  It resolves ticket 7599.  First reported by dhill.

This was generated with the following perl script:

 #!/usr/bin/perl -w -i -p

 s/\blog\(LOG_(ERR|WARN|NOTICE|INFO|DEBUG)\s*,\s*/log_\L$1\(/g;

 s/\blog\(/tor_log\(/g;