Closes ticket 32695.

We use bool, so we should include stdbool.

This frees us from a dependency on include order.

This change means that authmode.h no longer needs to see
or_options_t, and frees us from an ordering dependency.

Without this change, compilation success depends on include order in
several tricky ways.

This prevents a dependency on include order.

This fixes a case where our compilation would depend on include order.

Without this include, our compilation depends more on include order.

This lets us avoid a dependency on include order.

This frees us from some dependencies on include order.

This frees us from some dependencies on include order.

Doing this frees us from some assumptions about include order.

Using these frees us from several dependencies on include order.

Doing this gives us a valid uint64_t type, freeing us from
dependencies on include order.

This frees us from a dependency on include order.

This frees us from some dependencies on include order.

This gives us the definition of tor_x509_cert_impl_t, and makes us
less dependent on include order.

Otherwise our compilation depends on include order.

Also, include torerr.h from ht.h if we are using raw_assert.

Otherwise, our includes need to be ordered so that ht.h comes after
util_log.h.

We were actually omitting the semicolon in a few places, leading to
confusing indentation and some cocci failures.

This is an automated commit, generated by:

perl -i -pe 'next if /define/; s/((?:ENABLE|DISABLE)_GCC_WARNING)\(([A-Za-z0-9_\-]+)\)/$1(\"-W$2\")/' src/*/*/*.[ch] src/*/*.[ch]

teor authored 5 years ago and Nick Mathewson committed 5 years ago

If they are inconsistent, output a raw bug log.

Part of 32845.

Also, add a CTASSERT() to make sure that we don't let this array get
out-of-sync again.

Found by coverity; this is CID 1457528.

These test cases are validated differently by some
programming languages, because those languages have
incorrect UTF-8 implementations.

We want to make sure that tor validates them correctly.

Closes ticket 32845.