First, specify -Werror when we are testing each option; if it causes
a warning to appear, we shouldn't be adding it.

Second, do not attempt to add these options until after we have
found the libraries we want.  Previously, I would hit a bug where
the linker hardening options worked fine when we weren't linking
anything, but failed completely once we added openssl or libevent.

This is a matter of making gcc and friends squirm more loudly when
they get an option they don't like (-pedantic) and making clang shut
up with it gets an option it tolerates but doesnt know
(-Qunknown-argument).

Is there no better way?

Also, make the check for whether they're on by default work; there's
no need to mess around with this "$enableval" silliness.

Discovered by Kevin Bauer. Fixes bug 5373; bugfix on 0.2.3.9-alpha,
where task 4552 added support for two layers of torrc files.

Conflicts:
	src/or/circuitbuild.c

If you set ExitNodes so that only 1 exit node is accepted, the
previous patch would have made you unable to build circuits.

Conflicts:
	src/or/routerlist.c

Previously, malformatted torrc values could crash us.

Patch by Esteban Manchado.  Fixes bug 5090; fix on 0.2.0.16-alpha.

Esteban Manchado Velázquez authored 13 years ago and Nick Mathewson committed 13 years ago

* This assertion fails when executing the whole suite, but not when executing
  this test by itself
* Ideally I'd prefer starting with a guaranteed empty directory, but it's not
  very important in this case as non-existence of other paths is being checked
  explicitly

Esteban Manchado Velázquez authored 13 years ago and Nick Mathewson committed 13 years ago

* Add some more test cases
* Switch to test_assert et al