Refactor check_location_for_unix_socket()/check_location_for_socks_unix_socket() to eliminate duplicated code

Jacob Appelbaum authored 10 years ago and Andrea Shepard committed 10 years ago

Signed-off-by: Andrea Shepard <andrea@torproject.org>

Have clients and authorities both have new behavior, since the
fix for bug 11243 has gone in.  But make clients still accept
accept old bogus HSDir descriptors, to avoid fingerprinting trickery.

Fixes bug 9286.

Conflicts:
	src/or/or.h

If we're not a relay, we ignore it.

If it's set to 1, we obey ExitPolicy.

If it's set to 0, we force ExitPolicy to 'reject *:*'

And if it's set to auto, then we warn the user if they're running an
exit, and tell them how they can stop running an exit if they didn't
mean to do that.

Fixes ticket 10067

In systemd 209, they deprecated -lsystemd-daemon in favor of
-lsystemd.  So we'd better actually look at the pkg-config output,
or we'll get warnings on newer distributions.

For some as-yet-unknown-to-me reason, setting CFLAGS so early makes
it so -O2 -g doesn't get added to it later.  So, adding it myself
later.  Perhaps a better fix here can be found.

Fixes 14072; bugfix on 0.2.6.2-alpha.  Based on a patch from h.venev

Patch from Gisle Vanem on tor-dev ml

Closes ticket 14107.

Fixes 14116; bugfix on ac68704f in 0.2.2.9-alpha.

Fixes bug 14106; bugfix on 0.2.6.2-alpha

Found by stem tests.

This happened because we changed AutomapHostsSuffixes to replace "."
with "", since a suffix of "" means "match everything."  But our
option handling code for CSV options likes to remove empty entries
when it re-parses stuff.

Instead, let "." remain ".", and treat it specially when we're
checking for a match.

Fixes bug 12509; bugfix on 0.2.0.1-alpha.

(I'm tired of rewriting this by hand every January)