Part of ticket 30984.

Simplify handle_control_getinfo() by using the new reply lines
abstraction.  Previously, this function explicitly checked for whether
it should generate a MidReplyLine, a DataReplyLine, or an
EndReplyLine.  control_write_reply_lines() now abstracts this check.

Part of #30984.

Simplify handle_control_protocolinfo() by using the new reply line
abstraction.

Part of #30984.

Factor out the parts of handle_control_protocolinfo() that assemble
the AUTHMETHODS and COOKIEFILE strings.

Part of #30984.

In handle_control_getconf(), use the new control reply line
abstraction to simplify output generation.  Previously, this function
explicitly checked for whether it should generate a MidReplyLine or an
EndReplyLine.  control_write_reply_lines() now abstracts this check.

Part of #30984.

Part of #30984.

Add the KV_RAW flag to kvline_encode().  This allows generation of
output that is compatible with some quirks of the control protocol.

Part of #30984.

Add a check for '=' characters in needs_escape().  This simplifies the
logic in kvline_can_encode_lines().

Part of #30984.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

"ours" to avoid version bump.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

All of these files contain "*.h", except for:
* src/app/config/.may_include
* src/test/.may_include
which also contain "*.inc".

This change prevents includes of "*.c" files, and other
unusually named files.

Part of 32609.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

Extra testing after 32613.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

Part of 32522.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

Add a check-practracker-unit-test target, and run it as part of
"make check".

Add the practracker unit tests to scripts/git/pre-commit.git-hook.

Part of 32609.

Found by Stem regression tests. Reported by atagar.

Fixes #32664

Signed-off-by: David Goulet <dgoulet@torproject.org>