I had incorrectly identified these functions as dircache-only, when
in fact they apply to everyone who acts a directory client.

To make Tor still work, we define a minimal dircache_stub.c file
that defines the entry points to the module that can actually be
seen by the compiler when we're building with dircache and relay
disabled.

This is cleaner than iterating over the spool.

This function had some XXX comments indicating (correctly) that it
was not actually used by the dirserver code, and that only the
controller still used it.

Only directory caches actually need to spool things.

For now, this module is enabled whenever the relay module is
enabled, and disabled whenever the relay module is disabled.  Though
they are logically separate, the use cases for running one without
the other are rare enough that we don't really want to support
compiling them independently.

teor authored 5 years ago and Nick Mathewson committed 5 years ago

If they are inconsistent, output a raw bug log.

Part of 32845.

Also, add a CTASSERT() to make sure that we don't let this array get
out-of-sync again.

Found by coverity; this is CID 1457528.

These test cases are validated differently by some
programming languages, because those languages have
incorrect UTF-8 implementations.

We want to make sure that tor validates them correctly.

Closes ticket 32845.

Patch from opara.  Closes ticket 32779.

Peter Gerber authored 5 years ago and Peter Gerber committed 5 years ago

Allow calls to dup() which was introduced in commit a22fbab9.

From a security perspective, I don't think this should impact the
security of the sandbox significantly. As far as I can tell, there
is nothing an adversary can do with a duplicated FD that can't be
done with the original.