Does not implement TransportControlPort yet.

I added this so I could write a unit test for ServerTransportOptions,
but it incidentally exercises the succeed-on-defaults case of
options_validate too.

This removes some INLINE markers from functions that probably didn't
need them.

Conflicts:
	src/test/test_pt.c

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

Since we are going to be using that function to also escape parameters
passed to transport proxies using environment variables.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

This is in preparation for using tor_escape_str_for_socks_arg() to
escape server-side pluggable transport parameters.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

And use it to validate them.

Fix for #9254.  Bugfix on 0.2.4.14-alpha.

This is not actually a bug in the Tor code.

We used to test parse_{c,s}method_line() without actually testing that
the resulting transport_t was well formed.