cypherpunks authored 8 years ago and Nick Mathewson committed 8 years ago

The Autoconf macro AC_USE_SYSTEM_EXTENSIONS defines preprocessor macros
which turn on extensions to C and POSIX. The macro also makes it easier
for developers to use the extensions without needing (or forgetting) to
define them manually.

The macro can be safely used because it was introduced in Autoconf 2.60
and Tor requires Autoconf 2.63 and above.

All of our code just uses parse_config_line_from_str_verbose.

Also, add tests for it in case someday it does become reachable.

I'm not angry, Windows: just very disappointed.

When deleting an ephemeral HS, we were only iterating on circuit with an
OPEN state. However, it could be possible that an intro point circuit didn't
reached the open state yet.

This commit makes it that we close the circuit regardless of its state
except if it was already marked for close.

Fixes #18604

Signed-off-by: David Goulet <dgoulet@torproject.org>

Also note a bug in the rate-limiting message.

it's important, and we should make sure we got it right.

Fix for bug 19428.

I found some bugs in tv_mdiff; separate commit for that

I audited this to make sure I was only marking ones that really
should be unreachable.

'ours' merge to avoid bumping version.

The FetchHidServDescriptors check was placed before the descriptor cache
lookup which made the option not working because it was never using the
cache in the first place.

Fixes #18704

Patched-by: twim
Signef-off-by: David Goulet <dgoulet@torproject.org>

This is an "ours" merge to avoid taking a version bump.

Another part of 19406

It triggers on the openssl headers, and doesn't seem to actually
help us.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

Just as it says on the tin.  Don't need to fully disable any tests and
reduce coverage either.  Yay me.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

This is a logging onlu change, we were suppressing the severity down to
INFO when it occured (treating it as "Mostly harmless").  Now it is no
more.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

There's accessors to get at things, but it ends up being rather
cumbersome.  The only place where behavior should change is that the
code will fail instead of attempting to generate a new DH key if our
internal sanity check fails.

Like the previous commit, this probably breaks snapshots prior to pre5.

Yawning Angel authored 8 years ago and Nick Mathewson committed 8 years ago

Instead of `ERR_remove_thread_state()` having a modified prototype, it
now has the old prototype and a deprecation annotation.  Since it's
pointless to add extra complexity just to remain compatible with an old
OpenSSL development snapshot, update the code to work with 1.1.0pre5
and later.