These were previously allowed only in the initial position:
  --help, -h , --version, --digests, --list-torrc-options

Fix for bug 9578.

There were only two functions outside of circuitstats that actually
wanted to know what was inside this.  Making the structure itself
hidden should help isolation and prevent us from spaghettifying the
thing more.

(These have proved invaluable for other global accessors.)

vagrant authored 11 years ago and Nick Mathewson committed 11 years ago

Change the global circ_times to a static variable and use
accessor functions throughout the code, instead of
accessing it directly.

Fix for bug 9564; bugfix on 0.2.3.14-alpha.

Peter Retzlaff authored 11 years ago and Nick Mathewson committed 11 years ago

Implements ticket 5526.

Fix for bug 9543.

The spec requires them to do so, and not doing so creates a situation
where they can't send-test because relays won't extend to them because
of the other part of bug 9546.

Fixes bug 9546; bugfix on 0.2.3.6-alpha.

The spec requires them to do so, and not doing so creates a situation
where they can't send-test because relays won't extend to them because
of the other part of bug 9546.

Fixes bug 9546; bugfix on 0.2.3.6-alpha.

(Backport to Tor 0.2.3)

Relays previously, when initiating a connection, would only send a
NETINFO after sending an AUTHENTICATE.  But bridges, when receiving a
connection, would never send AUTH_CHALLENGE.  So relays wouldn't
AUTHENTICATE, and wouldn't NETINFO, and then bridges would be
surprised to be receiving CREATE cells on a non-open circuit.

Fixes bug 9546.

Relays previously, when initiating a connection, would only send a
NETINFO after sending an AUTHENTICATE.  But bridges, when receiving a
connection, would never send AUTH_CHALLENGE.  So relays wouldn't
AUTHENTICATE, and wouldn't NETINFO, and then bridges would be
surprised to be receiving CREATE cells on a non-open circuit.

Fixes bug 9546.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

- Set conn->address when we receive a USERADDR command.
- Set conn->state to a sane value when we transition from Extended
  ORPort to ORPort.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

We started allocating space for them on the heap in the previous
commit.

Conflicts:
	src/or/ext_orport.h

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

Use the generic function for both the ControlPort cookie and the
ExtORPort cookie.

Also, place the global cookie variables in the heap so that we can
pass them around more easily as pointers.

Also also, fix the unit tests that broke by this change.

Conflicts:
	src/or/config.h
	src/or/ext_orport.c

(Okay, white-box plus mocking enough other functions so they don't
crash.)

Incidentally, this business here where I make crypto_rand mockable:
this is exactly the kind of thing that would make me never want to
include test-support stuff in production builds.