Back in #1240, r1eo linked to information about how this could happen
with older Linux kernels in response to nmap.  Bugs #4545 and #4547
are about how our approach to trying to deal with this condition was
broken and stupid.  Thanks to wanoskarnet for reminding us about #1240.

This is a fix for the abovementioned bugs, and is a bugfix on
0.1.0.3-rc.

--enable-gcc-warnings enables two warnings that clang doesn't support,
so the build fails. We had hoped clang 3.0 would add those, but it
didn't, so let's just always disable those warnings when building with
clang. We can still fix it later once they add support

Fixes bug 4531; partial backport of e27a26d5.

Fixes bug 4535; bugfix on 0.2.2.28-beta; found by "troll_un"

Fix on 0.2.1.5-alpha; reported by troll_un

This avoids a possible strdup of an uninitialized buffer.

Fixes 4529; fix on 0.2.1.3-alpha; reported by troll_un.

Sebastian Hahn authored 13 years ago and Nick Mathewson committed 13 years ago

Backport of 68475fc5 which accidentally
only made it into master. Fixes bug 4547. Bug isn't in any released
version.

Now it will be easier for researchers to simulate Tor networks with
different values. Resolves ticket 4484.

this gets rid of a warning about signed/unsigned comparison

This is a backport of 0a5338e0 that
accidentally only went into master

This is a backport of bed79c47 which
accidentally only went into master

The function is over 10 or 20% on some of Moritz's profiles, depending
on how you could.

Since it's checking for a multi-hour timeout, this is safe to do.

Fixes bug 4518.

Completely disable stats if we aren't running as a relay. We won't
collect any anyway, so setting up the infrastructure for them and
logging about them is wrong. This also removes a confusing log
message that clients without a geoip db would have seen.

Fixes bug 4353.

Reported by "troll_un"; bugfix on 0.2.0.10-alpha; fixes bug 4349.

In Tor 0.2.2, we never need the event base to be notifiable, since we
don't call it from other threads.  This is a workaround for bug 4457,
which is not actually a Tor bug IMO.

The old behavior was susceptible to the compiler optimizing out our
assertion check, *and* could still overflow size_t on 32-bit systems
even when it did work.

STMT_VOID semantics suggested by nick, thanks!

Dan Rosenberg authored 13 years ago and Sebastian Hahn committed 13 years ago

Fixes bug 4410.