Skip to content
Snippets Groups Projects
  1. Jul 16, 2013
  2. Jul 08, 2013
  3. Jul 03, 2013
    • Nick Mathewson's avatar
      FIx undefined behavior in dirvote.c · 15cd79f8
      Nick Mathewson authored
       Fix a bug in the voting algorithm that could yield incorrect results
       when a non-naming authority declared too many flags. Fixes bug 9200;
       bugfix on 0.2.0.3-alpha.
      
      Found by coverity scan.
      15cd79f8
  4. Jun 29, 2013
  5. Jun 24, 2013
  6. Jun 18, 2013
  7. Jun 17, 2013
  8. Jun 15, 2013
  9. Jun 14, 2013
  10. Jun 13, 2013
  11. Jun 12, 2013
    • Nick Mathewson's avatar
      Make all consumers of microdesc_t.body tolerate NULL · e602c403
      Nick Mathewson authored
      This is another fix to try to mitigate recurrences of 8031/8822.
      e602c403
    • Nick Mathewson's avatar
      Unmap the microdescriptor cache before replacing it. · f455686b
      Nick Mathewson authored
      This is a reprise of the fix in bdff7e32; 6905c1f6 reintroduced
      that bug.  Briefly: windows doesn't seem to like deleting a mapped
      file.  I tried adding the PROT_SHARED_DELETE flag to the createfile
      all, but that didn't actually fix this issue.  Fortunately, the unit
      test I added in 4f4fc63f should
      prevent us from making this particular screw-up again.
      
      This patch also tries to limit the crash potential of a failure to
      write by a little bit, although it could do a better job of retaining
      microdescriptor bodies.
      
      Fix for bug 8822, bugfix on 0.2.4.12-alpha.
      f455686b
    • Nick Mathewson's avatar
      Revert "Use the FILE_SHARE_DELETE flag for CreateFile on a mapping" · fff9386a
      Nick Mathewson authored
      This reverts commit 884a0e26.
      
      I'm reverting this because it doesn't actually make the problem go
      away.  It appears that instead we need to do unmap-then-replace.
      fff9386a
    • Nick Mathewson's avatar
    • Nick Mathewson's avatar
      Use the FILE_SHARE_DELETE flag for CreateFile on a mapping · 884a0e26
      Nick Mathewson authored
      A comment by rransom on #8795 taken together with a comment by doorss
      recorded on #2077 suggest that *every* attempt to replace the md cache
      will fail on Vista/Win7 if we don't have the FILE_SHARE_DELETE flag
      passed to CreateFile, and if we try to replace the file ourselves
      before unmapping it.  I'm adding the FILE_SHARE_DELETE, since that's
      this simplest fix.  Broken indexers (the favored #2077 hypothesis)
      could still cause trouble here, but at least this patch should make us
      stop stepping on our own feet.
      
      Likely fix for #2077 and its numerous duplicates. Bugfix on
      0.2.2.6-alpha, which first had a microdescriptor cache that would get
      replaced before remapping it.
      884a0e26
    • Nick Mathewson's avatar
      Expand microdesc cache tests · 4f4fc63f
      Nick Mathewson authored
      Is it possible that *every* attempt to replace the microdesc cache on
      windows 7 is going to fail because of our lack of FILE_SHARE_DELETE
      while opening the file?  If so, this test will catch #2077 and let us
      know when it's fixed.
      4f4fc63f
  12. Jun 10, 2013
Loading