John Brooks authored 14 years ago and Nick Mathewson committed 14 years ago

Fix for #2358

Suggested by rransom.  Probably necessary for testing network mode.

When calling circuit_build_times_shuffle_and_store_array, we were
passing a uint32_t as an int.  arma is pretty sure that this can't
actually cause a bug, because of checks elsewhere in the code, but
it's best not to pass a uint32_t as an int anyway.

Found by doorss; fix on 0.2.2.4-alpha.

We detect and reject said attempts if there is no chosen exit node or
circuit: connecting to a private addr via a randomly chosen exit node
will usually fail (if all exits reject private addresses), is always
ill-defined (you're not asking for any particular host or service),
and usually an error (you've configured all requests to go over Tor
when you really wanted to configure all _remote_ requests to go over
Tor).

This can also help detect forwarding loop requests.

Found as part of bug2279.

Fixes part of bug 2279.  Bugfix on 0.1.2.1-alpha.

This bug was noticed by cypherpunks; fixes bug 2378.

Bugfix on svn commit r110.

Mike Perry authored 14 years ago and Nick Mathewson committed 14 years ago

Left circuit_build_times_get_bw_scale() uncommented because it is in the wrong
place due to an improper bug2317 fix. It needs to be moved and renamed, as it
is not a cbt parameter.

Mike Perry authored 14 years ago and Nick Mathewson committed 14 years ago

Do not add Exit bandwidth to E if BadExit is set.