Once again allow the flag to be set, unless the default network is used.
Thanks to nickm for a suggestion for the workaround to a test failure.

This reverts commit 27fa4a98.

David Goulet authored 7 years ago and Nick Mathewson committed 7 years ago

A v3 service can have between 0 and 20 intro points where v2 has 0 to 10.

Fixes #24115

Signed-off-by: David Goulet <dgoulet@torproject.org>

Note that it will have no effect yet; note that the default is
"any".

Roger Dingledine authored 8 years ago and Nick Mathewson committed 7 years ago

Bridge relays can use it to add a "bridge-distribution-request" line
to their bridge descriptor, which tells BridgeDB how they'd like their
bridge address to be given out.

Implements tickets 18329.

Add more explanation in doc/HACKING about how to read gcov output,
including a reference to the gcov documentation in the GCC manual.
Also add details about how our postprocessing scripts modify gcov
output.

'check-changes' is now part of "make check", and must pass.

Don't refer to the obsolete (and misspelled)
UseEntryGuardsAsDirectoryGuards config parameter in the manpage.

Closes 21405.

addr-spec.txt also explains this, but we should get it into the
manpage too.

Closes ticket #18736.

Fixes #23580

Signed-off-by: David Goulet <dgoulet@torproject.org>

It's been deprecated since 0.2.9.2-alpha.  Closes ticket 23426.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Martin Kepplinger authored 7 years ago and Nick Mathewson committed 7 years ago

doc/HACKING/GettingStarted.md says "you might like reading doc/HACKING",
which the reader obviously is already doing. Instead point to the "torguts"
documents that are mentioned a few lines below too.

We don't require that the final line be terminated, and we open
windows torrc files in text mode.

Closes ticket 22795.

Closes ticket 19704.

teor authored 7 years ago and Nick Mathewson committed 7 years ago

But when clients are just starting, make them try each bridge a few times
before giving up on it.

These changes make the bridge download schedules more explicit: before
17750, they relied on undocumented behaviour and specific schedule
entries. (And between 17750 and this fix, they were broken.)

Fixes 23347, not in any released version of tor.

teor authored 7 years ago and Nick Mathewson committed 7 years ago

The download schedule tells Tor to wait 15 minutes before downloading
bridge descriptors. But 17750 made Tor ignore that and start immediately.
Since we fixed 17750, Tor waits 15 minutes for bridge client bootstrap,
like the schedule says.

This fixes the download schedule to start immediately, and to try each
bridge 3 times in the first 30 seconds. This should make bridge bootstraps
more reliable.

Fixes 23347.

His full name is: Simon Deziel.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Undeprecate it;
rename it to TestingClientDNSRejectInternalAddresses;
add the old name as an alias;
reject configurations where it is set but TestingTorNetwork is not;
change the documentation accordingly.

Closes tickets 21031 and 21522.

 * THANKS TO Henry de Valence for review.

 * FIXES #22818

Documentation fix on commit 667ba776, which was part of #20534.