Sebastian Hahn authored 13 years ago and Nick Mathewson committed 13 years ago

Found by using clang's analyzer.

Sebastian Hahn authored 13 years ago and Nick Mathewson committed 13 years ago

Issue discovered using clang's static analyzer

Sebastian Hahn authored 13 years ago and Nick Mathewson committed 13 years ago

Make that explicit by adding an assert and removing a null-check. All of
its callers currently depend on the argument being non-null anyway.
Silences a few clang complaints.

Sebastian Hahn authored 13 years ago and Nick Mathewson committed 13 years ago

This possible div by 0 warning from clang's analyzer was quite fun to
track down. Turns out the current behaviour is safe.

Sebastian Hahn authored 13 years ago and Nick Mathewson committed 13 years ago

The analyzer assumed that bootstrap_percent could be less than 0 when we
call control_event_bootstrap_problem(), which would mean we're calling
log_fn() with undefined values. The assert makes it clear this can't
happen.

Fixes bug 3106.

Fixes bug 2379

Previously we ensured that it would get called periodically by doing
it from inside the code that added microdescriptors.  That won't work
though: it would interfere with our code that tried to read microdescs
from disk initially.  Instead, we should consider rebuilding the cache
periodically, and on startup.

Previously on 0.2.2, we'd never clean the cache.  Now that we can
clean it, we want to add a condition to rebuild it: that should happen
whenever we have dropped enough microdescriptors that we could save a
lot of space.

No changes file, since 0.2.3 doesn't need one and 0.2.2 already has some
changes files for the backport of the microdesc_clean_cahce() function.

Otherwise we have no way to keep authorities' microdesc caches in 0.2.2
from growing without bound.

This could be one reason that authorities' journals would grow without
bound; related to bug 2230. Bugfix on 0.2.2.6-alpha.  Fix by
"cypherpunks".

Clients and relays haven't used them since early 0.2.0.x.  The only
remaining use by authorities learning about new relays ahead of scedule;
see proposal 147 for what we intend to do about that.

We're leaving in an option (FetchV2Networkstatus) to manually fetch v2
networkstatuses, because apparently dnsel and maybe bwauth want them.

This fixes bug 3022.

Fix bug 3020.