[CID 1234702, 1234703]

Found by Coverity Scan.

[CID 1234704, 1234705, 1234706]

(We have a tests-shouldn't-leak policy so that we won't accidentally
ignore true-positives.)

Sebastian Hahn authored 10 years ago and Nick Mathewson committed 10 years ago

This implements a feature from bug 13000. Instead of starting a bwauth
run with this wrong idea about their bw, relays should do the self-test
and then get measured.

Sebastian Hahn authored 10 years ago and Nick Mathewson committed 10 years ago

When a tor relay starts up and has no historical information about its
bandwidth capability, it uploads a descriptor with a bw estimate of 0.
It then starts its bw selftest, but has to wait 20 minutes to upload the
next descriptor due to the MAX_BANDWIDTH_CHANGE_FREQ delay. This change
should mean that on average, relays start seeing meaningful traffic a
little quicker, since they will have a higher chance to appear in the
consensus with a nonzero bw.

Patch by Roger, changes file and comment by Sebastian.

This fixes a clangalyzer warning, and makes our C slightly better C.

The clangalyzer hates (void*)101 etc

They hate this.

The clangalyzer doesn't believe our math here.  I'm pretty sure our
math is right.  Also, add some unit tests.

This should stop a false positive from the clangalyzer.

Also, make MALLOC_ZERO_WORKS never get applied when clang analyzer is
running.  This should make the clangalyzer a little happier.

We're calling mallocfn() and reallocfn() in the HT_GENERATE macro
with the result of a product.  But that makes any sane analyzer
worry about overflow.

This patch keeps HT_GENERATE having its old semantics, since we
aren't the only project using ht.h.  Instead, define a HT_GENERATE2
that takes a reallocarrayfn.

Most of these are in somewhat non-obvious code where it is probably
a good idea to initialize variables and add extra assertions anyway.

Closes 13036.  Patches from "teor".

Philip Van Hoof authored 10 years ago and Nick Mathewson committed 10 years ago

(Edited to use existing ARRAY_LENGTH macro --nickm)

It's now a protocol-warn, since there's nothing relay operators can
do about a client that sends them a malformed create cell.

Resolves bug 12996; bugfix on 0.0.6rc1.

Instead of putting it all in one warning message, log what exactly
was wrong with the circuit.

Resolves ticket 12997.

dana koch authored 10 years ago and Nick Mathewson committed 10 years ago

This is using the paradigm introduced for test_status.c.

Roger Dingledine authored 10 years ago and Nick Mathewson committed 10 years ago

The fix for bug 4647 accidentally removed our hack from bug 586 that
rewrote HashedControlPassword to __HashedControlSessionPassword when
it appears on the commandline (which allowed the user to set her own
HashedControlPassword in the torrc file while the controller generates
a fresh session password for each run).

Fixes bug 12948; bugfix on 0.2.5.1-alpha.

This way, we don't get locking failures when we hit an assertion in
the unit tests.  Also, we might find out about unit test bugs from
folks who can't do gdb.

It had been used in consensus method 1.  But now that 13 is the
minimum (see #10163), we don't need it around.

Found by sysrqb.

This is related to the rest of 523587a5

Using the *_array() functions here confused coverity, and was actually
a bit longer than we needed.  Now we just use macros for the repeated
bits, so that we can mention a file and a suffix-appended version in
one line.

Conflicts:
	src/or/circuitlist.c