George Kadianakis authored 12 years ago and Nick Mathewson committed 11 years ago

* Change name of init_ext_or_auth_cookie_authentication().
* Add a small comment.

George Kadianakis authored 12 years ago and Nick Mathewson committed 11 years ago

Move the code from the connection_or module to ext_orport.

This commit only moves code: it shouldn't modify anything.

George Kadianakis authored 12 years ago and Nick Mathewson committed 11 years ago

* Add documentation.
* Free ext_or_auth_correct_client_hash.
* Use VPORT(ExtORPort) instead of V(ExtORPOrt).
  See dfe03d36 for details.

Does not implement TransportControlPort yet.

I added this so I could write a unit test for ServerTransportOptions,
but it incidentally exercises the succeed-on-defaults case of
options_validate too.

This removes some INLINE markers from functions that probably didn't
need them.

Conflicts:
	src/test/test_pt.c

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

Since we are going to be using that function to also escape parameters
passed to transport proxies using environment variables.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

This is in preparation for using tor_escape_str_for_socks_arg() to
escape server-side pluggable transport parameters.

George Kadianakis authored 11 years ago and Nick Mathewson committed 11 years ago

And use it to validate them.