Server Bindaddr Args testcase correction

jmwamplerequested to merge
jmwample/goptlib:main into main

fix incorrect testcase for server bindaddr parsing. One example uses the "," character to separate argument sets which should (based on the spec) result in one long unsplit argument.

# (Previous)
"alpha:k1=v1,beta:k2=v2,gamma:k3=v3"  =>  "alpha": {"k1": ["v1,beta:k2=v2,gamma:k3=v3"] }

# (Updated)
"alpha:k1=v1;beta:k2=v2;gamma:k3=v3"  => "alpha": {"k1": ["v1"]}, "beta": {"k2": ["v2"]}, "gamma": {"k3": ["v3"] }

Merge request reports

pt_test.go

+11 −2
Changes for pt_test.go: 11 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -275,7 +275,7 @@ func TestResolveAddr(t *testing.T) { 


func bindaddrSliceContains(s []Bindaddr, v Bindaddr) bool {

	for _, sv := range s {

		if sv.MethodName == v.MethodName && tcpAddrsEqual(sv.Addr, v.Addr) {

		if sv.MethodName == v.MethodName && tcpAddrsEqual(sv.Addr, v.Addr) && argsEqual(sv.Options, v.Options) {

			return true

		}

	}
@@ -354,12 +354,21 @@ func TestGetServerBindaddrs(t *testing.T) { 
		{

			"alpha-1.2.3.4:1111,beta-[1:2::3:4]:2222",

			"alpha,beta,gamma",

			"alpha:k1=v1,beta:k2=v2,gamma:k3=v3",

			"alpha:k1=v1;beta:k2=v2;gamma:k3=v3",

			[]Bindaddr{

				{"alpha", &net.TCPAddr{IP: net.ParseIP("1.2.3.4"), Port: 1111}, Args{"k1": []string{"v1"}}},

				{"beta", &net.TCPAddr{IP: net.ParseIP("1:2::3:4"), Port: 2222}, Args{"k2": []string{"v2"}}},

			},

		},

		{

			"alpha-1.2.3.4:1111,beta-[1:2::3:4]:2222",

			"alpha,beta,gamma",

			"alpha:k1=v1,beta:k2=v2,gamma:k3=v3",

			[]Bindaddr{

				{"alpha", &net.TCPAddr{IP: net.ParseIP("1.2.3.4"), Port: 1111}, Args{"k1": []string{"v1,beta:k2=v2,gamma:k3=v3"}}},

				{"beta", &net.TCPAddr{IP: net.ParseIP("1:2::3:4"), Port: 2222}, Args{}},

			},

		},

		{

			"alpha-1.2.3.4:1111",

			"xxx",