Moved MainActivity to MVP

closes #17 (closed)

assigned to @cohosh and unassigned @HashikD

@cohosh most of the code is moved from MainActivity to MainActivityModel. Please test and let me know if there are any issues.

marked as a Work In Progress

added 1 commit

• 121c52c1 - Removed onDestroy MainActivityModel

Compare with previous version

added 2 commits

• 1102b25c - Removed onDestroy MainActivityModel
• 3c049a86 - Moved SharedPreferences to constants to increase cohesion in presenter

Compare with previous version

added 1 commit

• 6c8056d2 - Added contract interface

Compare with previous version

added 1 commit

• 3ae09964 - Changed MainActivityMVP to MainActivityMVP contract

Compare with previous version

unmarked as a Work In Progress

This is a nitpick, but can we change this to AppPreferenceKeys? It increases code readability slightly, otherwise it looks like we're declaring the counts of users served or the date as final constants.

Okay, thanks for working on this! Just writing here for my own notes to make sure I understand the design:

You've separated the main activity into two parts: the presenter (that takes care of responding to user inputs and getting the information to the user), and the model (which acts as an interface between the presenter and storage).

Almost right, but little changes...

View(UI where user interacts) <=> Presenter <=> model(Fetches data and makes network calls)

The presenter mediates between the model and view. For instance, If the user clicks on the "refresh page", the View will tell the presenter and presenter will tell Model to fetch new content after model fetches the content asynchronously it calls a method on presenter and presenter will, in turn, say to the UI to update giving it the latest data.

Let me know if it wasn't clear, I know I can be bad at explaining things so don't hesitate.

Okay great, thanks! And the view will be added later with the UI implementation, right?

Actually, it is already implemented if you look at the MainActivity class, it implements the View interface from MainActivityMVP (Which is called as a Contract Interface) so MainActivity is the View now.

merged

mentioned in merge request !13 (merged)