Remove uniuri dependency

uniuri is only used in a minor way, to generate a random string for local identification of a snowflake client.

added component::circumvention/snowflake in Legacy / Trac owner::dcf in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels

Trac:
0001-Remove-uniuri-dependency.patch

This patch replaces uniuri.New() with a manual call to crypto/rand.Read. Panicking on read error is the same thing uniuri does. 8 hex-encoded bytes are the same length as uniuri.New(), but only 64 bits compared to uniuri.New()'s ~95 bits (16 characters of base-62).

Trac:
Status: assigned to needs_review

The code looks fine and the only place I see this being used is the datachannel label which has no uniqueness requirements.

https://developer.mozilla.org/en-US/docs/Web/API/RTCDataChannel/label

Does that change with turbotunnel? If not, I'd say merge ready.

Thanks for the review. Merged as 8eef3b63482deb50d988e3703b7a718802cdd2f1.

Now, we just have to remember to actually remove the dependency from Tor Browser the next time we update Snowflake there.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved from legacy/trac#33800 (moved)

added Feature label and removed 1 deleted label

removed 1 deleted label

mentioned in issue tpo/applications/tor-browser-build#40342 (closed)

mentioned in commit dcf/tor-browser-build@5e61e15a

mentioned in merge request tpo/applications/tor-browser-build!322 (merged)

mentioned in commit sysrqb/tor-browser-build@edeef651