Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S Snowflake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Anti-censorship
  • Pluggable Transports
  • Snowflake
  • Merge requests
  • !130

fix(proxy): up/down traffic stats being mixed up

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed WofWca requested to merge WofWca/snowflake:swap-up-down-stats into main Jan 12, 2023
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 2

We look from the client's perspective. When it sends data to the server, we say it's outbound traffic. When the server sends data to the client, it's inbound traffic:

  • https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/blob/7db2568448fed6d883b33db11e3a497c69f1748f/proxy/lib/snowflake.go#L414
  • https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/blob/7db2568448fed6d883b33db11e3a497c69f1748f/proxy/lib/webrtcconn.go#L78

But in the log messages they are mixed up, which results in "up" traffic being usually thicker than "down":

image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: swap-up-down-stats