SetNAT1To1IPs can take multiple IPs. For #40108 (closed) specifically I think it makes sense to only accept one IP and single argument is much easier to work with
flag. But I'm open to change if there are legit cases where one would want a priority IP group instead of a single priority IP.
- The library doesn't check whether the provided IP is authentic: it simply replaces the all
hostcandidates (due to
webrtc.ICECandidateTypeHost) of the SDP answer with the provided IP. This should be fine in most cases because we have
srflxcandidate to fall back on. (host candidates have higher priority than srflx candidates in most implementations)
- I didn't know a lot about probetest before working on this MR and the logging/comments in code didn't make the most sense to me. So I've modified quite a few places as I learn about how they work. Open to feedback.
- With my changes it's possible that we are logging too frequently (every SDP offer/answer pair) and too much (including attributes like
ice-pwdin verbose mode. I think we are also logging them in broswer extension. I'm not sure how much it helps in debugging or if it's a security/privacy risk. Will do more reserach on it.