Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S Snowflake
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 89
    • Issues 89
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Anti-censorship
  • Pluggable Transports
  • Snowflake
  • Merge requests
  • !140

Revert "Take ownership of buffer in QueuePacketConn QueueIncoming/WriteTo"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged David Fifield requested to merge dcf/snowflake:40260-revert-queuepacketconn-ownership into main Mar 13, 2023
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

This reverts commit 839d2218. (Except for the added benchmarks in queuepacketconn_test.go.) This change corresponds to the issues #40187 (closed) and #40199 (closed).

The analysis in #40199 (closed) was wrong; kcp-go does reuse the buffers it passes to QueuePacketConn.WriteTo. This led to unsynchronized reuse of packet buffers and mangled packets observable at the client: #40260 (closed).

Undoing the change in QueuePacketConn.QueueIncoming as well, for symmetry, even though it is not implicated in any correctness problems.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 40260-revert-queuepacketconn-ownership