- 13 Oct, 2019 1 commit
-
-
MickeyMoz authored
-
- 12 Oct, 2019 2 commits
-
-
MozLando authored
4268: Pass redirect source and target flags to history tracking delegates r=rocketsroger a=linacambridge There's some confusion in `GeckoEngineSession` about redirect flags. The `VISIT_REDIRECT_SOURCE` and `VISIT_REDIRECT_SOURCE_PERMANENT` flags that we get from GeckoView's history delegate are for the redirect _source_, not the visit type. They indicate if the URL passed to `onVisited` is redirecting _to_ another URL, most likely because the server returned an HTTP 3xy status code with a `Location` header. Rust Places decides whether to mark the URL as hidden based on these flags. `VISIT_REDIRECT_{PERMANENT, TEMPORARY}`, however, indicate if the URL passed to `onVisited` is the _target_ of a redirect (in other words, the page that's _in_ the `Location` header). These get translated into `VisitType` flags, which Rust Places stores as the visit transition type. These two flags don't affect whether a URL is hidden. Note that, in a redirect chain, the middle links are both sources and targets. For example, in "mozilla.org" -> "www.mozilla.org" -> "www.mozilla.org/en-US", "www.mozilla.org" is both a redirect target (since "mozilla.org" redirected to it), and a source (it redirected to "www.mozilla.org/en-US"). See mozilla-mobile/fenix#3526. Co-authored-by:
Lina Cambridge <lina@yakshaving.ninja>
-
Lina Cambridge authored
There's some confusion in `GeckoEngineSession` about redirect flags. The `VISIT_REDIRECT_SOURCE` and `VISIT_REDIRECT_SOURCE_PERMANENT` flags that we get from GeckoView's history delegate are for the redirect _source_, not the visit type. They indicate if the URL passed to `onVisited` is redirecting _to_ another URL, most likely because the server returned an HTTP 3xy status code with a `Location` header. Rust Places decides whether to mark the URL as hidden based on these flags. `VISIT_REDIRECT_{PERMANENT, TEMPORARY}`, however, indicate if the URL passed to `onVisited` is the _target_ of a redirect (in other words, the page that's _in_ the `Location` header). These get translated into `VisitType` flags, which Rust Places stores as the visit transition type. These two flags don't affect whether a URL is hidden. Note that, in a redirect chain, the middle links are both sources and targets. For example, in "mozilla.org" -> "www.mozilla.org" -> "www.mozilla.org/en-US", "www.mozilla.org" is both a redirect target (since "mozilla.org" redirected to it), and a source (it redirected to "www.mozilla.org/en-US"). See mozilla-mobile/fenix#3526.
-
- 11 Oct, 2019 9 commits
-
-
MickeyMoz authored
-
MickeyMoz authored
-
ssaqua authored
-
Ahmed I. Khalil authored
-
MickeyMoz authored
-
Arturo Mejia authored
-
Simon Chae authored
This allows EngineViewBottomBehavior.onDependentViewChanged() to call setVerticalClipping on any nested EngineView
-
MozLando authored
4716: Fix snapshots: (publish.gradle) Do not override "timestamp" property. r=Amejia481,JohanLorenzo a=pocmo This broke our snapshots since `getTimestamp()` overrides the `timestamp` property that our scripts pass in when building snapshots. Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com>
-
Sebastian Kaspari authored
-
- 10 Oct, 2019 7 commits
-
-
MozLando authored
4709: Closes #4666: Dynamically support JSON extra file from GeckoView r=pocmo a=rocketsroger Co-authored-by:
Roger Yang <royang@mozilla.com>
-
Roger Yang authored
-
MozLando authored
4708: Docs update (20191010-121507) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
MozLando authored
4670: Sort out Treeherder display by putting all snapshot/release jobs... r=JohanLorenzo a=JohanLorenzo ... under tier 1 This will make https://treeherder.mozilla.org/#/jobs?repo=android-components&revision=48f8d633d2b89c3008f188fa939e27f6ea16eb5a easier to read because there will be less groups to display. Co-authored-by:
Johan Lorenzo <jlorenzo@mozilla.com>
-
MozLando authored
4697: Update glean_parser version to 1.9.3 r=Dexterp37 a=brizental The new version adds functionaly to show labels from Labeled types on the Extras column in the Markdown template. Co-authored-by:
Beatriz Rizental <beatriz.rizental@gmail.com>
-
MozLando authored
4683: No issue: bump a-s to 0.41.0 r=grigoryk a=vladikoff Release notes: https://github.com/mozilla/application-services/releases cc @grigoryk Co-authored-by:
Vlad Filippov <vlad.filippov@gmail.com>
-
- 09 Oct, 2019 15 commits
-
-
MozLando authored
4695: Closes #4681: Support observing engine state changes for web extensions r=pocmo a=csadilek Co-authored-by:
Christian Sadilek <christian.sadilek@gmail.com>
-
Christian Sadilek authored
-
MozLando authored
4657: Closes #2887: Allow reporting exceptions without crashing r=[travis79,pocmo] a=rocketsroger Co-authored-by:
Roger Yang <royang@mozilla.com>
-
Roger Yang authored
-
MozLando authored
4696: 1566488: Persist start_times to avoid 0 between start and end r=mdboom a=mdboom Co-authored-by:
Michael Droettboom <mdboom@gmail.com>
-
Michael Droettboom authored
-
Michael Droettboom authored
-
MozLando authored
4649: Closes #4636 - Add ShareTarget data class r=Amejia481 a=NotWoods Co-authored-by:
Tiger Oakes <toakes@mozilla.com>
-
MozLando authored
4634: Add more descriptive instructions to README.md [ci skip] r=Amejia481 a=espertus Co-authored-by:
Ellen Spertus <ellen.spertus@gmail.com>
-
Ellen Spertus authored
-
Beatriz Rizental authored
-
Tiger Oakes authored
-
MozLando authored
4689: feature-contextmenu: Do not show download confirmation dialog for "save image". r=csadilek a=pocmo Fixing Fenix issue: https://github.com/mozilla-mobile/fenix/issues/952 4692: Import strings from android-l10n. r=pocmo a=mozilla-l10n-automation-bot n/t 4694: Docs update (20191009-121304) [ci skip] r=pocmo a=MickeyMoz Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com> Co-authored-by:
Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com> Co-authored-by:
MickeyMoz <sebastian@mozilla.com>
-
MickeyMoz authored
-
Mozilla L10n Automation Bot authored
-
- 08 Oct, 2019 6 commits
-
-
MozLando authored
4674: 1586881: Fix high error rate on glean.baseline.duration r=mdboom a=mdboom There is a race condition in how the TimingManager is used here. When stopping a timer, we dispatch a task to actually record the value in the timespan, and only reset the TimingManager in that async task after the recording, which requires I/O, is complete. If the timespan is started in the meantime, an error will be recorded, rather than safely starting a new timespan measurement. This change could be considered on the principle (followed elsewhere), that we do timing management and measurement synchronously, and only recording asynchronously. Co-authored-by:
Michael Droettboom <mdboom@gmail.com>
-
Sebastian Kaspari authored
-
MozLando authored
4641: For #4639 Change menu button ripple to circular (unbounded) r=pocmo a=mcarare Co-authored-by:
mcarare <mihai.carare.dev@gmail.com>
-
MozLando authored
4598: For issue #4369 Use MATCH_ALL flag when resolving browsers r=pocmo a=ForceTower 4687: Docs update (20191008-121003) [ci skip] r=pocmo a=MickeyMoz 4688: Set version to 17.0.0. r=MickeyMoz,MozLando a=pocmo Co-authored-by:
ForceTower <joaopaulo761@gmail.com> Co-authored-by:
MickeyMoz <sebastian@mozilla.com> Co-authored-by:
Sebastian Kaspari <s.kaspari@gmail.com>
-
Sebastian Kaspari authored
-
MickeyMoz authored
-