Verify Sentry is disabled

# Error/crash monitoring
sentry -> io.sentry:sentry-android

added 1 deleted label

mentioned in issue #40009 (closed)

changed milestone to %Tor Browser: 10.0

Sentry is used in three places.

1. Crash reporting
2. Monitoring "lost encrypted passwords"
3. Monitoring run-time errors when moving between screens in the app

1. https://gitlab.torproject.org/tpo/applications/fenix/-/blob/tor-browser-79.0-10.0-1/app/src/main/java/org/mozilla/fenix/components/Analytics.kt#L42

        if (isSentryEnabled()) {
            val sentryService = SentryService(
                context,
                BuildConfig.SENTRY_TOKEN,
                tags = mapOf("geckoview" to "$MOZ_APP_VERSION-$MOZ_APP_BUILDID"),
                environment = BuildConfig.BUILD_TYPE,
                sendEventForNativeCrashes = false, // Do not send native crashes to Sentry
                sentryProjectUrl = getSentryProjectUrl()
            )   

            services.add(sentryService)
        }   

fun isSentryEnabled() = !BuildConfig.SENTRY_TOKEN.isNullOrEmpty()

2. https://gitlab.torproject.org/tpo/applications/fenix/-/blob/tor-browser-79.0-10.0-1/app/src/main/java/org/mozilla/fenix/components/Core.kt#L271

    private val passwordsEncryptionKey by lazy {
        getSecureAbove22Preferences().getString(PASSWORDS_KEY)
            ?: generateEncryptionKey(KEY_STRENGTH).also {
                if (context.settings().passwordsEncryptionKeyGenerated) {
                    // We already had previously generated an encryption key, but we have lost it
                    Sentry.capture("Passwords encryption key for passwords storage was lost and we generated a new one")                                                                                    
                }   
                context.settings().recordPasswordsEncryptionKeyGenerated()
                getSecureAbove22Preferences().putString(PASSWORDS_KEY, it) 
            }   
    }

3. https://gitlab.torproject.org/tpo/applications/fenix/-/blob/tor-browser-79.0-10.0-1/app/src/main/java/org/mozilla/fenix/ext/NavController.kt#L62

fun recordIdException(actual: Int?, expected: Int?) {                                                                                                                                                       
    if (isSentryEnabled()) {
        Sentry.capture("Fragment id $actual did not match expected $expected")
    }   
}

We can completely delete the sentry dependency from Fenix without too much difficulty. But the isSentryEnabled() conditional is safe for Tor Browser because we should never provide a SENTRY_TOKEN at build time, so moving (2) into a isSentryEnabled() conditional block should be sufficient.

changed time estimate to 3h

added 1h of time spent at 2020-08-05

But the isSentryEnabled() conditional is safe for Tor Browser because we should never provide a SENTRY_TOKEN at build time, so moving (2) into a isSentryEnabled() conditional block should be sufficient.

We should think about how we can test/confirm this remains true in the future.

https://github.com/mozilla-mobile/fenix/pull/13362

https://github.com/mozilla-mobile/fenix/pull/13362

We can backport to 80 if this lands soon.

https://github.com/mozilla-mobile/fenix/pull/13362

We can backport to 80 if this lands soon.

Landed. https://github.com/mozilla-mobile/fenix/commit/a1b7e61d36a323bc0ef93df6b7d40fac660cc3f4

added 1 deleted label and removed 1 deleted label

assigned to @sysrqb

removed 1 deleted label

added Next label

It looks like we're done here.

closed