Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • F fenix
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 67
    • Issues 67
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • fenix
  • Merge requests
  • !1

Bug 33594 05 80.0b6

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Matthew Finkel requested to merge sysrqb/fenix:bug_33594_05_80.0b6 into tor-browser-80.0b6-10-1 Aug 13, 2020
  • Overview 1
  • Commits 5
  • Pipelines 1
  • Changes 8

This is the first set of Fenix patches

In b67e786f16b29c5c2188173a8c2b20d46719e5d5 we define a new compile-time constant for DATA_COLLECTION_DISABLED. This constant is used in the code for setting the default value of telemetry being enabled/disabled. I am hoping this patch is a reasonable starting place for uplifting.

In d58cc9b5e179dd180ce2510134aa551406d89510 we avoid throwing the IllegalStateException exception when we are in a Release and DATA_COLLECTION_DISABLED is true (so that exception is thrown only when data collection is enabled).

In aa6d757c14a6f5babde2746d1e0d3bfb1e625436 we change the default crash reporter state from "always enabled" to "only enabled if DATA_COLLECTION_DISABLED is false".

In 695bc630de6e97a1a66233da7b3db7d14125d898 we rip out the Google Advertising ID support. Adding the @Suppress("UNUSED_PARAMETER") annotation is important because the compiler errors when a method's signature contains an unused parameter.

In eaf28c70934e1993abe3afe8d3adb5e9516f1309 we simply disable the background service, for defense-in-depth.

Closes #33594 (closed) #40019 (closed) android-components#34338 (closed) #40014 (closed) #40018 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bug_33594_05_80.0b6