Bug 40177: Hide Tor icons in settings

mentioned in issue #40177 (closed)

Thanks for the patch! For some reason I see the space for the icon is still reserved for our menu items. I don't see an obvious reason why. Did you test this and it looks correct?

I was planning on hiding the icon for the donation button, too, but I'm okay with keeping it in this case.

requested review from @sysrqb

assigned to @HackerNCoder

assigned to @sysrqb and unassigned @HackerNCoder

I don't see an obvious reason why.

Neither do I, I have little knowledge of how it all works, but I hoped android:iconSpaceReserved="false" would do it.

Edit: Wait, I can't read. It should be app:iconSpaceReserved, going to make a fixup for that

Did you test this and it looks correct?

No, I haven't tested it.

added 1 commit

• a5664eed - fixup! Bug 40177: Hide Tor icons in settings

Compare with previous version

marked this merge request as draft from HackerNCoder/fenix@a5664eed4380f66c8b8524969629fd4be568db3b

marked this merge request as ready

Thanks! Indeed, that looks like it was the problem. I can't test it right now, but I'll land it and we can look at it in the nightly build tomorrow.

merged