Skip to content

Bug 33594 07 80.0b6

Matthew Finkel requested to merge sysrqb/fenix:bug_33594_07_80.0b6 into tor-browser-80.0b6-10-1

This is the first set of Fenix patches

In fcd470fd9de6e7d66bcc02f5448ce40f69b409a9 we change the applicationId (it must be different from all other apps). We use org.torproject as the base name.

In 4da9e0856dd75fbc1c23f729c7f25c4a57388337 we change the (branding) app name.

In 740c63c76f26110dfe8a88eeb0f1aa0b70bb0c58 we define a new compile-time constant for DATA_COLLECTION_DISABLED. This constant is used in the code for setting the default value of telemetry being enabled/disabled. I am hoping this patch is a reasonable starting place for uplifting.

In 2d8824cec5a006ca39647dd747b65e51e9cdc565 we avoid throwing the IllegalStateException exception when we are in a Release and DATA_COLLECTION_DISABLED is true (so that exception is thrown only when data collection is enabled).

In 93280d2413ab907a2fb7fd25b06c9e1debea7af9 we change the default crash reporter state from "always enabled" to "only enabled if DATA_COLLECTION_DISABLED is false".

In fedc1dc6aa1dfdbc8d842c8e21128dee4da9dd96 we rip out the Google Advertising ID support. Adding the @Suppress("UNUSED_PARAMETER") annotation is important because the compiler errors when a method's signature contains an unused parameter.

In 2e665b7e1aecd7c10ef85ef22173899abad15ea8 we simply disable the background service, for defense-in-depth.

Note, all tests pass except for one and it is flaky.

Closes #40020 (closed) #33594 (closed) #40019 (closed) android-components#34338 (closed) #40014 (closed) #40018 (closed)

Merge request reports