Skip to content

Bug 42578: Reject Android "open in Tor Browser" intent

ma1 requested to merge ma1/firefox-android:bug42578_13_5 into firefox-android-115.2.1-13.5-1

Merge Info

Related Issues

  • tor-browser#42578
  • tor-browser#42409

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

It rejects open intent, refusing to open web pages sent explicitly to the Tor Browser from other apps.

Setting the Tor Browser as the default browser keeps working as expected.

How Tested

Verified the STR in the bug and that default browser works using the release-based testbuild here: https://tb-build-02.torproject.org/~ma1/builds/testbuild/bug42578_open_intent/

Edited by ma1

Merge request reports