Skip to content

Bug 42590: Fix home fragment app name text view for larger text sizes

Merge Info

Related Issues

Backporting

Timeline

  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Other: please explain

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

Text view in top left of the home fragment/base browser screen should now properly fully display the app name regardless of text size. Other changes were also made to generally make it look better (i.e the text should also be centered with the Icon and the icon is slightly larger now)

Screenshot_2024-06-20_at_12.40.00-> Screenshot_2024-06-20_at_12.41.37

It also looks better with the default text size, and properly displays the "dev" in this case

Screenshot_2024-06-20_at_12.43.38 -> Screenshot_2024-06-20_at_12.43.30

It also displays "alpha" properly, whereas it didn't before

Screenshot_2024-06-20_at_12.50.38

How Tested

Launch the app and bootstrap as normal to get to the home fragment/base browser screen. Notice in the top left the logo and text displays properly. Now go into the phone settings and increase "font size" (and "display size" if you want, it should work with that as well) and go back to the home screen in tor browser and notice that the top left it still displays correctly.

Edited by clairehurst

Merge request reports