Bug_42323: Add opt-in UI and wiring for beta connection features (html vs android native + new connection assist)
Merge Info
Related Issues
Backporting
Timeline
-
Immediate: patchset needed as soon as possible -
Next Minor Stable Release: patchset that needs to be verified in nightly before backport -
Eventually: patchset that needs to be verified in alpha before backport -
No Backport (preferred): patchset for the next major stable
(Optional) Justification
-
Emergency security update: patchset fixes CVEs, 0-days, etc -
Censorship event: patchset enables censorship circumvention -
Critical bug-fix: patchset fixes a bug in core-functionality -
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc -
Sponsor required: patchset required for sponsor -
Other: please explain
Issue Tracking
-
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Request Reviewer
-
Request review from an applications developer depending on modified system: -
NOTE: if the MR modifies multiple areas, please
/cc
all the relevant reviewers (since gitlab only allows 1 reviewer) - accessibility : henry
- android : clairehurst, dan
- build system : boklm
- extensions : ma1
- firefox internals (XUL/JS/XPCOM) : ma1
- fonts : pierov
- frontend (implementation) : henry
- frontend (review) : donuts, richard
- localization : henry, pierov
- macos : clairehurst, dan
- nightly builds : boklm
- rebases/release-prep : dan, ma1, pierov, richard
- security : ma1
- signing : boklm, richard
- updater : pierov
- misc/other : pierov, richard
-
NOTE: if the MR modifies multiple areas, please
Change Description
How Tested
- Open app
- Tap on "Tor Network" settings (either by tapping on the cog in the top right of the old bootstrap screen or by tapping on "Tor Network" in the regular settings)
- Notice there's a new preference at the bottom called "Enable beta connection features" and tap on it
- Notice the new UI in this new screen. You can now tap on "Enable beta connection features"
- By default it auto selects "HTML UI" in the radio preferences below. (Native android should crash right now if you attempt to load it since its not implemented in this MR (see !48 (merged) for more details on the native implementation)
- Hit back a few times until you get back to the connection screen and the appropriate screen should be loaded (And the HTML page should have the toolbar hidden) (Note that after connecting from the HTML connection assist it loads about:tor which is a broken page, and the toolbar is still hidden. To get around this hit back to get out of that screen)
Edited by clairehurst