Commit 0f657df0 authored by Nazım Can Altınova's avatar Nazım Can Altınova
Browse files

Bug 1728544 - Make the MarkerSchema::Searchable enum class values CamelCased r=gerald 

Differential Revision: https://phabricator.services.mozilla.com/D124242
parent a38b25b2

mozglue/baseprofiler/core/ProfilerMarkers.cpp

+1 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ void MarkerSchema::Stream(JSONWriter& aWriter, 
                if (aData.mSearchable) {

                  aWriter.BoolProperty(

                      "searchable",

                      *aData.mSearchable == Searchable::searchable);

                      *aData.mSearchable == Searchable::Searchable);

                }

              },

              [&aWriter](const StaticData& aStaticData) {

mozglue/baseprofiler/public/BaseProfilerMarkersPrerequisites.h

+1 −1
Original line number Diff line number Diff line
@@ -740,7 +740,7 @@ class MarkerSchema { 
    Decimal

  };



  enum class Searchable { notSearchable, searchable };

  enum class Searchable { NotSearchable, Searchable };



  // Marker schema, with a non-empty list of locations where markers should be

  // shown.

mozglue/tests/TestBaseProfiler.cpp

+1 −1
Original line number Diff line number Diff line
@@ -4543,7 +4543,7 @@ void TestUserMarker() { 
      MS schema{MS::Location::MarkerChart, MS::Location::MarkerTable};

      schema.SetTooltipLabel("tooltip for test-minimal");

      schema.AddKeyLabelFormatSearchable("text", "Text", MS::Format::String,

                                         MS::Searchable::searchable);

                                         MS::Searchable::Searchable);

      return schema;

    }

  };

tools/profiler/gecko/ProfilerIOInterposeObserver.cpp

+3 −3
Original line number Diff line number Diff line
@@ -38,12 +38,12 @@ struct FileIOMarker { 
              MS::Location::TimelineFileIO};

    schema.AddKeyLabelFormatSearchable("operation", "Operation",

                                       MS::Format::String,

                                       MS::Searchable::searchable);

                                       MS::Searchable::Searchable);

    schema.AddKeyLabelFormatSearchable("source", "Source", MS::Format::String,

                                       MS::Searchable::searchable);

                                       MS::Searchable::Searchable);

    schema.AddKeyLabelFormatSearchable("filename", "Filename",

                                       MS::Format::FilePath,

                                       MS::Searchable::searchable);

                                       MS::Searchable::Searchable);

    return schema;

  }

};

tools/profiler/tests/gtest/GeckoProfiler.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1775,10 +1775,10 @@ TEST(GeckoProfiler, Markers) 
                               MS::Format::FilePath);

      schema.AddKeyFormatSearchable("key with string not-searchable",

                                    MS::Format::String,

                                    MS::Searchable::notSearchable);

                                    MS::Searchable::NotSearchable);

      schema.AddKeyLabelFormatSearchable("key with label duration searchable",

                                         "label duration", MS::Format::Duration,

                                         MS::Searchable::searchable);

                                         MS::Searchable::Searchable);

      schema.AddKeyFormat("key with time", MS::Format::Time);

      schema.AddKeyFormat("key with seconds", MS::Format::Seconds);

      schema.AddKeyFormat("key with milliseconds", MS::Format::Milliseconds);