Bug 1697991 - Enable Dark Mode support in the crash reporter client, and fix a...

Bug 1697991 - Enable Dark Mode support in the crash reporter client, and fix a case of black-on-black text. r=mac-reviewers,bradwerth

Differential Revision: https://phabricator.services.mozilla.com/D108151

toolkit/crashreporter/client/crashreporter_osx.mm

@@ -189,12 +189,14 @@ static bool RestartApplication() {
 }
 
 - (void)showReportInfo {
-  NSDictionary* boldAttr =
-      [NSDictionary dictionaryWithObject:[NSFont boldSystemFontOfSize:[NSFont smallSystemFontSize]]
-                                  forKey:NSFontAttributeName];
-  NSDictionary* normalAttr =
-      [NSDictionary dictionaryWithObject:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]
-                                  forKey:NSFontAttributeName];
+  NSDictionary* boldAttr = @{
+    NSFontAttributeName : [NSFont boldSystemFontOfSize:[NSFont smallSystemFontSize]],
+    NSForegroundColorAttributeName : NSColor.textColor,
+  };
+  NSDictionary* normalAttr = @{
+    NSFontAttributeName : [NSFont systemFontOfSize:[NSFont smallSystemFontSize]],
+    NSForegroundColorAttributeName : NSColor.textColor,
+  };
 
   [mViewReportTextView setString:@""];
   for (Json::ValueConstIterator iter = gQueryParameters.begin(); iter != gQueryParameters.end();

toolkit/crashreporter/client/macbuild/Contents/Info.plist

@@ -27,7 +27,7 @@
 	<key>NSMainNibFile</key>
 	<string>MainMenu</string>
 	<key>NSRequiresAquaSystemAppearance</key>
-	<true/>
+	<false/>
 	<key>NSPrincipalClass</key>
 	<string>NSApplication</string>
 	<key>LSUIElement</key>