-
- Downloads
Bug 1754858 - Simplify screen orientation API implementation. r=smaug,m_kato,geckoview-reviewers
Make the ScreenOrientation part of the screen struct, as it should. Stop using HAL to propagate just screen orientation updates, use the more general screen manager. Instead of HAL observers, add a simple observer service notification, and clean a bunch of the code. This will simplify bug 1754802 a bit, and is generally simpler. Shouldn't change behavior. I've tested the events and some common orientation locking use cases like Youtube, and they behave the same. Differential Revision: https://phabricator.services.mozilla.com/D138477
Showing
- dom/base/ScreenOrientation.cpp 23 additions, 23 deletionsdom/base/ScreenOrientation.cpp
- dom/base/ScreenOrientation.h 12 additions, 7 deletionsdom/base/ScreenOrientation.h
- dom/base/WindowOrientationObserver.cpp 0 additions, 52 deletionsdom/base/WindowOrientationObserver.cpp
- dom/base/WindowOrientationObserver.h 0 additions, 34 deletionsdom/base/WindowOrientationObserver.h
- dom/base/moz.build 0 additions, 2 deletionsdom/base/moz.build
- dom/base/nsGlobalWindowInner.cpp 43 additions, 22 deletionsdom/base/nsGlobalWindowInner.cpp
- dom/base/nsGlobalWindowInner.h 11 additions, 11 deletionsdom/base/nsGlobalWindowInner.h
- dom/base/nsGlobalWindowOuter.cpp 0 additions, 11 deletionsdom/base/nsGlobalWindowOuter.cpp
- dom/base/nsGlobalWindowOuter.h 0 additions, 7 deletionsdom/base/nsGlobalWindowOuter.h
- dom/base/nsJSUtils.cpp 1 addition, 0 deletionsdom/base/nsJSUtils.cpp
- dom/base/nsScreen.cpp 19 additions, 0 deletionsdom/base/nsScreen.cpp
- dom/base/nsScreen.h 6 additions, 0 deletionsdom/base/nsScreen.h
- dom/ipc/DOMTypes.ipdlh 3 additions, 0 deletionsdom/ipc/DOMTypes.ipdlh
- hal/Hal.cpp 0 additions, 30 deletionshal/Hal.cpp
- hal/Hal.h 1 addition, 16 deletionshal/Hal.h
- hal/HalScreenConfiguration.h 0 additions, 3 deletionshal/HalScreenConfiguration.h
- hal/android/AndroidHal.cpp 0 additions, 22 deletionshal/android/AndroidHal.cpp
- hal/fallback/FallbackScreenConfiguration.cpp 3 additions, 14 deletionshal/fallback/FallbackScreenConfiguration.cpp
- hal/fallback/FallbackScreenConfiguration.h 0 additions, 30 deletionshal/fallback/FallbackScreenConfiguration.h
- hal/moz.build 0 additions, 4 deletionshal/moz.build
Loading
Please register or sign in to comment