Skip to content
Snippets Groups Projects
Commit 4d5c3500 authored by Byron Campen's avatar Byron Campen
Browse files

Bug 1401592: Make sure JSEP distinguishes unicast with rid from unicast without rid. r=mjf

parent b57f116e
No related branches found
No related tags found
No related merge requests found
......@@ -229,9 +229,7 @@ void JsepTrack::SendTrackSetRemote(SsrcGenerator& aSsrcGenerator,
mRids = std::move(newRids);
}
// Treat "simulcast" with one rid as unicast
if (mRids.size() <= 1) {
mRids.clear();
if (mRids.empty()) {
mRids.push_back("");
}
......
......@@ -271,8 +271,11 @@ class JsepTrack {
sdp::Direction mDirection;
std::vector<UniquePtr<JsepCodecDescription>> mPrototypeCodecs;
// List of rids. May be initially populated from JS, or from a remote SDP.
// Can be updated by remote SDP. For unicast, this will contain one element
// with the empty string.
// Can be updated by remote SDP. If no negotiation has taken place at all,
// this will be empty. If negotiation has taken place, but no simulcast
// attr was negotiated, this will contain the empty string as a single
// element. If a simulcast attribute was negotiated, this will contain the
// negotiated rids.
std::vector<std::string> mRids;
UniquePtr<JsepTrackNegotiatedDetails> mNegotiatedDetails;
std::vector<uint32_t> mSsrcs;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment