Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium

accessible/windows/ia2/moz.build

@@ -47,9 +47,6 @@ LOCAL_INCLUDES += [
 
 FINAL_LIBRARY = 'xul'
 
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']
-
 # The Windows MIDL code generator creates things like:
 #
 #   #endif !_MIDL_USE_GUIDDEF_

accessible/windows/msaa/moz.build

@@ -70,6 +70,3 @@ if CONFIG['CLANG_CL']:
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

accessible/windows/sdn/moz.build

@@ -20,6 +20,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

accessible/windows/uia/moz.build

@@ -18,6 +18,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

b2g/app/moz.build

@@ -71,9 +71,6 @@ if CONFIG['OS_ARCH'] == 'WINNT':
         'version',
     ]
 
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']
-
 JS_PREFERENCE_PP_FILES += [
     'b2g.js',
 ]

browser/app/moz.build

@@ -71,9 +71,6 @@ if CONFIG['MOZ_LINKER']:
 if CONFIG['HAVE_CLOCK_MONOTONIC']:
     OS_LIBS += CONFIG['REALTIME_LIBS']
 
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']
-
 for icon in ('firefox', 'document', 'newwindow', 'newtab', 'pbmode'):
     DEFINES[icon.upper() + '_ICO'] = '"%s/dist/branding/%s.ico"' % (
         TOPOBJDIR, icon)

browser/components/about/moz.build

@@ -17,6 +17,3 @@ FINAL_LIBRARY = 'browsercomps'
 LOCAL_INCLUDES += [
     '../build',
 ]
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

browser/components/build/moz.build

@@ -38,6 +38,3 @@ if CONFIG['OS_ARCH'] == 'WINNT':
 # GTK2: Need to link with glib for GNOME shell service
 if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('cocoa', 'gtk2', 'gtk3'):
     OS_LIBS += CONFIG['TK_LIBS']
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

browser/components/dirprovider/moz.build

@@ -17,6 +17,3 @@ FINAL_LIBRARY = 'browsercomps'
 LOCAL_INCLUDES += [
     '../build'
 ]
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

browser/components/feeds/moz.build

@@ -39,6 +39,3 @@ LOCAL_INCLUDES += [
 
 with Files('**'):
     BUG_COMPONENT = ('Firefox', 'RSS Discovery and Preview')
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

browser/components/shell/moz.build

@@ -60,6 +60,3 @@ CXXFLAGS += CONFIG['TK_CFLAGS']
 
 with Files('**'):
     BUG_COMPONENT = ('Firefox', 'Shell Integration')
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

devtools/server/moz.build

@@ -37,6 +37,3 @@ DevToolsModules(
     'service-worker-child.js',
     'worker.js'
 )
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

docshell/base/timeline/moz.build

@@ -40,6 +40,3 @@ FINAL_LIBRARY = 'xul'
 LOCAL_INCLUDES += [
     '/docshell/base'
 ]
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

docshell/build/moz.build

@@ -27,8 +27,5 @@ include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
 
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']
-
 if CONFIG['MOZ_DEVTOOLS'] == 'all':
     DEFINES['MOZ_DEVTOOLS_ALL'] = True

dom/activities/moz.build

@@ -38,6 +38,3 @@ LOCAL_INCLUDES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

dom/animation/moz.build

@@ -61,6 +61,3 @@ LOCAL_INCLUDES += [
 ]
 
 FINAL_LIBRARY = 'xul'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

dom/archivereader/moz.build

@@ -21,9 +21,6 @@ UNIFIED_SOURCES += [
     'ArchiveZipFile.cpp',
 ]
 
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']
-
 LOCAL_INCLUDES += [
     '../base',
 ]

dom/audiochannel/moz.build

@@ -24,6 +24,3 @@ UNIFIED_SOURCES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

dom/base/test/gtest/moz.build

@@ -15,6 +15,3 @@ LOCAL_INCLUDES += [
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul-gtest'
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']

dom/battery/moz.build

@@ -18,6 +18,3 @@ include('/ipc/chromium/chromium-config.mozbuild')
 FINAL_LIBRARY = 'xul'
 
 MOCHITEST_MANIFESTS += ['test/mochitest.ini']
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wshadow']