-
- Downloads
Bug 1747699 - Re-write bookmarks and folder creation for new non-instant apply...
Bug 1747699 - Re-write bookmarks and folder creation for new non-instant apply pattern r=mak,Standard8 Based on https://phabricator.services.mozilla.com/D141582. Updates the bookmark toolbar to delay creating new bookmarks and folders while "delayed apply" mode is enabled. One edge case which is not currently accounted for, is the case where user clicks on "Bookmark All Tabs", and then creates folders from within the dialog box, for example: {F4228947} In this case, the new folders will be created instantly, even if delayed apply is enabled. Cancelling the dialog box will remove them. (This is why we still need to use "batching", even in delayed apply mode.) Because of how the dialog is currently structured, it seems fairly complex to handle this case. I am not sure if it is within the scope of this project, open to advice. Differential Revision: https://phabricator.services.mozilla.com/D160554
Showing
- browser/components/places/PlacesUIUtils.sys.mjs 76 additions, 12 deletionsbrowser/components/places/PlacesUIUtils.sys.mjs
- browser/components/places/content/bookmarkProperties.js 11 additions, 4 deletionsbrowser/components/places/content/bookmarkProperties.js
- browser/components/places/content/editBookmark.js 21 additions, 5 deletionsbrowser/components/places/content/editBookmark.js
- browser/components/places/content/instantEditBookmark.js 10 additions, 0 deletionsbrowser/components/places/content/instantEditBookmark.js
- browser/components/places/tests/browser/browser_bookmarkProperties_bookmarkAllTabs.js 51 additions, 1 deletion...sts/browser/browser_bookmarkProperties_bookmarkAllTabs.js
- toolkit/components/places/Bookmarks.sys.mjs 5 additions, 0 deletionstoolkit/components/places/Bookmarks.sys.mjs
Loading
Please register or sign in to comment