Bug 1873210 - Support langpacks in the crashreporter client a=RyanVM
This passes the profile directory as a crash annotation (which is not sent in the crash report). The profile directory is already indirectly passed to the crash reporter through `MOZ_CRASHREPORTER_EVENTS_DIRECTORY`, however I don't think that's something to rely upon. The pref parsing and langpack extension search are done on a best-effort basis; there may be some odd configurations for which it does not account. However, it should cover the vast majority of cases. While we don't want to underserve niche populations that may have an odd configuration, we do always have fallback behaviors that are likely still reasonable for most (like using the installation locale). We also first try the `useragent_locale` annotation before getting locales from the prefs. This only looks in the profile and the installation for langpack extensions. There are a few other system-wide locations that Firefox looks in. However, the assumptions are: 1) overwhelmingly users install langpacks using the UI rather than manually downloading the file, and 2) if installed with a package manager (mostly applicable to linux), langpacks are put in the installation. This is the case for the few major linux distros I checked. If we think this is not enough, I can also add the system-wide directories. Original Revision: https://phabricator.services.mozilla.com/D222356 Differential Revision: https://phabricator.services.mozilla.com/D234210
Showing
- Cargo.lock 10 additions, 0 deletionsCargo.lock
- supply-chain/audits.toml 6 additions, 0 deletionssupply-chain/audits.toml
- third_party/rust/sys-locale/.cargo-checksum.json 1 addition, 0 deletionsthird_party/rust/sys-locale/.cargo-checksum.json
- third_party/rust/sys-locale/CHANGELOG.md 73 additions, 0 deletionsthird_party/rust/sys-locale/CHANGELOG.md
- third_party/rust/sys-locale/Cargo.lock 207 additions, 0 deletionsthird_party/rust/sys-locale/Cargo.lock
- third_party/rust/sys-locale/Cargo.toml 57 additions, 0 deletionsthird_party/rust/sys-locale/Cargo.toml
- third_party/rust/sys-locale/LICENSE-APACHE 201 additions, 0 deletionsthird_party/rust/sys-locale/LICENSE-APACHE
- third_party/rust/sys-locale/LICENSE-MIT 21 additions, 0 deletionsthird_party/rust/sys-locale/LICENSE-MIT
- third_party/rust/sys-locale/README.md 54 additions, 0 deletionsthird_party/rust/sys-locale/README.md
- third_party/rust/sys-locale/examples/get_locale.rs 11 additions, 0 deletionsthird_party/rust/sys-locale/examples/get_locale.rs
- third_party/rust/sys-locale/src/android.rs 75 additions, 0 deletionsthird_party/rust/sys-locale/src/android.rs
- third_party/rust/sys-locale/src/apple.rs 166 additions, 0 deletionsthird_party/rust/sys-locale/src/apple.rs
- third_party/rust/sys-locale/src/lib.rs 127 additions, 0 deletionsthird_party/rust/sys-locale/src/lib.rs
- third_party/rust/sys-locale/src/unix.rs 101 additions, 0 deletionsthird_party/rust/sys-locale/src/unix.rs
- third_party/rust/sys-locale/src/wasm.rs 56 additions, 0 deletionsthird_party/rust/sys-locale/src/wasm.rs
- third_party/rust/sys-locale/src/windows.rs 49 additions, 0 deletionsthird_party/rust/sys-locale/src/windows.rs
- third_party/rust/sys-locale/src/windows_sys.rs 22 additions, 0 deletionsthird_party/rust/sys-locale/src/windows_sys.rs
- third_party/rust/sys-locale/tests/wasm_worker.rs 15 additions, 0 deletionsthird_party/rust/sys-locale/tests/wasm_worker.rs
- toolkit/crashreporter/CrashAnnotations.yaml 5 additions, 0 deletionstoolkit/crashreporter/CrashAnnotations.yaml
- toolkit/crashreporter/client/app/Cargo.toml 1 addition, 0 deletionstoolkit/crashreporter/client/app/Cargo.toml
Loading
Please register or sign in to comment