Bug 1667455 - Part 2: Add Services to system globals in ESLint. r=kmag

Differential Revision: https://phabricator.services.mozilla.com/D150891

devtools/server/actors/watcher/browsing-context-helpers.jsm

@@ -14,8 +14,10 @@ const EXPORTED_SYMBOLS = [
 let Services;
 if (typeof module == "object") {
   // Allow this JSM to also be loaded as a CommonJS module
+  // eslint-disable-next-line no-global-assign
   Services = require("Services");
 } else {
+  // eslint-disable-next-line no-global-assign
   ({ Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"));
 }
 

toolkit/components/osfile/modules/osfile_shared_allthreads.jsm

@@ -37,6 +37,7 @@ if (typeof Components != "undefined") {
   // loader.
   // eslint-disable-next-line mozilla/reject-global-this
   this.exports = {};
+  // eslint-disable-next-line no-global-assign
   ({ Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"));
   // eslint-disable-next-line mozilla/reject-global-this
   this.Services = Services;

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -32,6 +32,7 @@ module.exports = {
     InstallTrigger: false,
     // https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/InternalError
     InternalError: true,
+    Services: false,
     // https://developer.mozilla.org/docs/Web/API/Window/dump
     dump: true,
     openDialog: false,