Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Mullvad Browser
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
The Tor Project
Applications
Mullvad Browser
Commits
bfe45adc
Commit
bfe45adc
authored
2 years ago
by
Byron Campen
Browse files
Options
Downloads
Patches
Plain Diff
Bug 1401592: Ignore duplicate rids in SDP. r=mjf
Differential Revision:
https://phabricator.services.mozilla.com/D157651
parent
b4c8201d
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
dom/media/webrtc/jsep/JsepTrack.cpp
+6
-1
6 additions, 1 deletion
dom/media/webrtc/jsep/JsepTrack.cpp
with
6 additions
and
1 deletion
dom/media/webrtc/jsep/JsepTrack.cpp
+
6
−
1
View file @
bfe45adc
...
...
@@ -377,10 +377,15 @@ void JsepTrack::GetRids(const SdpMediaSection& msection,
return
;
}
// RFC 8853 does not seem to forbid duplicate rids in a simulcast attribute.
// So, while this is obviously silly, we should be prepared for it and
// ignore those duplicate rids.
std
::
set
<
std
::
string
>
uniqueRids
;
for
(
const
SdpSimulcastAttribute
::
Version
&
version
:
*
versions
)
{
if
(
!
version
.
choices
.
empty
())
{
if
(
!
version
.
choices
.
empty
()
&&
!
uniqueRids
.
count
(
version
.
choices
[
0
].
rid
)
)
{
// We validate that rids are present (and sane) elsewhere.
rids
->
push_back
(
*
msection
.
FindRid
(
version
.
choices
[
0
].
rid
));
uniqueRids
.
insert
(
version
.
choices
[
0
].
rid
);
}
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment