Bug 1688609 - Add 'titulaire' to cc-name heuristic regex. r=dimi

Differential Revision: https://phabricator.services.mozilla.com/D124948

Bug 1688609 - Add 'titulaire' to cc-name heuristic regex. r=dimi
cabe439f · Tim Giles · 3294afd2 · cabe439f · cabe439f · cabe439f
Commit cabe439f authored 3 years ago by Tim Giles
--- a/browser/extensions/formautofill/test/fixtures/heuristics_fr_fields.html
+++ b/browser/extensions/formautofill/test/fixtures/heuristics_fr_fields.html
+<!DOCTYPE html>
+<html>
+
+<head>
+  <meta charset="UTF-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1.0">
+  <title>Heuristics fr-FR fields test page</title>
+</head>
+
+<body>
+  <h1>Heuristics fr-FR fields test page</h1>
+  <form name="cardForm">
+    <div>
+      <input id="cardNumber" autocomplete="off" name="cardNumber" maxlength="19" placeholder="**** **** **** ****"
+        type="tel" value="">
+      <label for="cardNumber">Numéro de carte *</label>
+    </div>
+    <div>
+      <input id="expiry" autocomplete="off" name="expiry" maxlength="5" placeholder="MM/AA" step="1" type="tel"
+        value="">
+      <label for="expiry">Date d'expiration *</label>
+    </div>
+    <div>
+      <input id="cvc" autocomplete="off" name="cvc" maxlength="3" placeholder="***" step="1" type="tel" value="">
+      <label for="cvc">Cryptogramme *</label>
+    </div>
+    <div>
+      <input id="name" autocomplete="off" name="name" placeholder="Nom Prénom" step="1" type="text" value="DOE JOHN">
+      <label for="name">Titulaire *</label>
+    </div>
+  </form>
+</body>
+
+</html>
--- a/browser/extensions/formautofill/test/unit/heuristics/test_fr_fields.js
+++ b/browser/extensions/formautofill/test/unit/heuristics/test_fr_fields.js
+/* Any copyright is dedicated to the Public Domain.
+http://creativecommons.org/publicdomain/zero/1.0/ */
+
+/* global runHeuristicsTest */
+
+"use strict";
+
+runHeuristicsTest(
+  [
+    {
+      fixturePath: "heuristics_fr_fields.html",
+      expectedResult: [
+        [
+          [
+            {
+              section: "",
+              addressType: "",
+              contactType: "",
+              fieldName: "cc-number",
+            },
+            {
+              section: "",
+              addressType: "",
+              contactType: "",
+              fieldName: "cc-exp",
+            },
+            {
+              section: "",
+              addressType: "",
+              contactType: "",
+              fieldName: "cc-name",
+            },
+          ],
+        ],
+      ],
+    },
+  ],
+  "../../fixtures/"
+);
--- a/browser/extensions/formautofill/test/unit/heuristics/xpcshell.ini
+++ b/browser/extensions/formautofill/test/unit/heuristics/xpcshell.ini
@@ -10,6 +10,7 @@ skip-if = (os == "linux") && ccov # bug 1614100
 skip-if = (os == "linux") && ccov # bug 1614100
 [test_de_fields.js]
 skip-if = (os == "linux") && ccov # bug 1614100
+[test_fr_fields.js]
 [test_known_strings.js]
 skip-if = (os == "linux") && ccov # bug 1614100
 [test_multiple_section.js]

--- a/toolkit/components/formautofill/content/heuristicsRegexp.js
+++ b/toolkit/components/formautofill/content/heuristicsRegexp.js
@@ -47,6 +47,7 @@ var HeuristicsRegExp = {
      "address-line3": "addrline3|address_3",
      "address-level1": "land", // de-DE
      "additional-name": "apellido.?materno|lastlastname",
+      "cc-name": "titulaire", // fr-FR
      "cc-number": "(cc|kk)nr", // de-DE
      "cc-exp-month": "(cc|kk)month", // de-DE
      "cc-exp-year": "(cc|kk)year", // de-DE