-
- Downloads
Bug 1718444 - Convert nsIUpdateCheckListener to async r=nalexander,application-update-reviewers
I want to be able to check if the update-available notification is fired during testing. The entry point to firing that notification is UpdateService.onCheckComplete, but it currently kicks off its work and does not wait for it to finish. This means that I can wait for the update-available notification to be fired, but I cannot easily wait for it NOT to be fired, which is what I want to be able to test here. It looks though like it should be easy enough to just convert this interface to an asynchronous one. This will make it much easier to call onCheckComplete and know by the end of it if the update-available notification gets fired or not. Differential Revision: https://phabricator.services.mozilla.com/D126162
Showing
- browser/components/newtab/lib/ASRouterTargeting.jsm 4 additions, 2 deletionsbrowser/components/newtab/lib/ASRouterTargeting.jsm
- browser/modules/AppUpdater.jsm 2 additions, 2 deletionsbrowser/modules/AppUpdater.jsm
- toolkit/mozapps/update/UpdateService.jsm 3 additions, 3 deletionstoolkit/mozapps/update/UpdateService.jsm
- toolkit/mozapps/update/nsIUpdateService.idl 5 additions, 3 deletionstoolkit/mozapps/update/nsIUpdateService.idl
- toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js 2 additions, 2 deletionstoolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js
- toolkit/mozapps/update/tests/unit_aus_update/multiUpdate.js 2 additions, 2 deletionstoolkit/mozapps/update/tests/unit_aus_update/multiUpdate.js
Loading
Please register or sign in to comment