Bug 1811487 - Clean-up popup hide / rollup APIs. r=cmartin
I'm about to extend them for bug 1811486, where I want to force in some cases the rolled up popups to hide synchronously. These APIs use a ton of boolean arguments that make them error prone, so refactor them a bit to use strongly typed enums and flags. Differential Revision: https://phabricator.services.mozilla.com/D167381
Showing
- browser/components/customizableui/test/browser_PanelMultiView_keyboard.js 3 additions, 5 deletions...ts/customizableui/test/browser_PanelMultiView_keyboard.js
- dom/xul/XULButtonElement.cpp 8 additions, 4 deletionsdom/xul/XULButtonElement.cpp
- dom/xul/XULPopupElement.cpp 7 additions, 2 deletionsdom/xul/XULPopupElement.cpp
- dom/xul/nsXULPopupListener.cpp 3 additions, 1 deletiondom/xul/nsXULPopupListener.cpp
- layout/xul/nsMenuBarListener.cpp 1 addition, 1 deletionlayout/xul/nsMenuBarListener.cpp
- layout/xul/nsMenuPopupFrame.cpp 3 additions, 1 deletionlayout/xul/nsMenuPopupFrame.cpp
- layout/xul/nsXULPopupManager.cpp 85 additions, 77 deletionslayout/xul/nsXULPopupManager.cpp
- layout/xul/nsXULPopupManager.h 26 additions, 27 deletionslayout/xul/nsXULPopupManager.h
- layout/xul/nsXULTooltipListener.cpp 1 addition, 1 deletionlayout/xul/nsXULTooltipListener.cpp
- view/nsView.cpp 2 additions, 3 deletionsview/nsView.cpp
- widget/cocoa/nsChildView.mm 6 additions, 4 deletionswidget/cocoa/nsChildView.mm
- widget/cocoa/nsCocoaWindow.mm 1 addition, 1 deletionwidget/cocoa/nsCocoaWindow.mm
- widget/cocoa/nsMenuX.mm 1 addition, 1 deletionwidget/cocoa/nsMenuX.mm
- widget/cocoa/nsToolkit.mm 1 addition, 1 deletionwidget/cocoa/nsToolkit.mm
- widget/gtk/nsWindow.cpp 44 additions, 45 deletionswidget/gtk/nsWindow.cpp
- widget/gtk/nsWindow.h 2 additions, 1 deletionwidget/gtk/nsWindow.h
- widget/nsBaseDragService.cpp 1 addition, 1 deletionwidget/nsBaseDragService.cpp
- widget/nsIRollupListener.h 16 additions, 13 deletionswidget/nsIRollupListener.h
- widget/windows/nsWindow.cpp 10 additions, 6 deletionswidget/windows/nsWindow.cpp
Loading
Please register or sign in to comment