-
- Downloads
Bug 1704500: Run Windows' ILocation provider in a utility process r=emilio,cmartin
Previously, the ILocation COM object ran in the main process. Due to a race condition, it would sometimes crash the process so we are moving it to a utility process, where it can crash safely. The old WindowsLocationProvider class has become a proxy that forwards requests to the child process via the PWindowsLocation parent actor. The PWindowsLocationChild executes the requests and sends the results back. Failures in ILocation (like geolocation being off in Windows settings) are sent back as well -- they will cause the WindowsLocationProvider to start the MLS geolocation fallback, as they did before. Additionally, this patch caches the accuracy setting in order to guarantee the proper accuracy is set when requesting reports. Previously, we called SetHighAccuracy too early and it was silently not set (bug 1773456). Depends on D155019 Differential Revision: https://phabricator.services.mozilla.com/D155020
Showing
- dom/system/windows/PWindowsLocation.ipdl 38 additions, 0 deletionsdom/system/windows/PWindowsLocation.ipdl
- dom/system/windows/PWindowsUtils.ipdl 7 additions, 0 deletionsdom/system/windows/PWindowsUtils.ipdl
- dom/system/windows/WindowsLocationChild.cpp 257 additions, 0 deletionsdom/system/windows/WindowsLocationChild.cpp
- dom/system/windows/WindowsLocationChild.h 44 additions, 0 deletionsdom/system/windows/WindowsLocationChild.h
- dom/system/windows/WindowsLocationParent.cpp 36 additions, 0 deletionsdom/system/windows/WindowsLocationParent.cpp
- dom/system/windows/WindowsLocationParent.h 52 additions, 0 deletionsdom/system/windows/WindowsLocationParent.h
- dom/system/windows/WindowsLocationProvider.cpp 217 additions, 164 deletionsdom/system/windows/WindowsLocationProvider.cpp
- dom/system/windows/WindowsLocationProvider.h 42 additions, 14 deletionsdom/system/windows/WindowsLocationProvider.h
- dom/system/windows/WindowsUtilsChild.h 6 additions, 0 deletionsdom/system/windows/WindowsUtilsChild.h
- dom/system/windows/moz.build 8 additions, 0 deletionsdom/system/windows/moz.build
Loading
Please register or sign in to comment