The goal is to move this lower-level code somewhere where it can be
reused.

The only meaningful code change as part of the move was handling
of the mach context. Before, we could access self._mach_context.
After, we need to pass it as an argument. This also uncovered a bug
where "telemetry_handler" could be None but we called it
unconditionally. We now guard this call with an "if."

MozReview-Commit-ID: FWw4l6H1ayS

--HG--
extra : rebase_source : f6bf25eb8c52df2d09e4d5eddd5b85b38502e661

In general, we shouldn't have so much business logic in mach_commands.py
files.

I'd like to move more of the low-level "perform a build" logic out of
mach_commands.py to facilitate some future work. That code makes use of
this output processing code. So as the first step in moving the build
code, we move its dependencies.

As part of this, I also cleaned up some random unused imports around
lines that were touched.

No meaningful code changes were performed as part of the code move.

MozReview-Commit-ID: 96mGWUJ7oLb

--HG--
extra : rebase_source : 04c3865d5bcc44777749f3ab6a65e31bb1d13689

MozReview-Commit-ID: GSDYk9wLOAM

--HG--
rename : browser/base/content/test/general/browser_bug561636.js => browser/modules/test/browser/formValidation/browser_form_validation.js
rename : browser/base/content/test/general/browser_bug595507.js => browser/modules/test/browser/formValidation/browser_validation_iframe.js
rename : browser/modules/test/browser/browser_bug1319078.js => browser/modules/test/browser/formValidation/browser_validation_invisible.js

servo: Merge #19086 - style: Move font-weight outside of mako (from cbrewster:font_weight_nomako); r=emilio

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are apart of #19015 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1e0fd7da3050208621dd08044bb202570638fb3e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 11e30e17839a10dbfda8f88055392c025652c722

Backed out changeset 769dd8ce70e1 (bug 1413257) for failing flake8 at /builds/worker/checkouts/gecko/build/moz.configure/toolchain.configure r=backout on a CLOSED TREE

Accidentally slipped through the first patch.

MozReview-Commit-ID: GoFbMBuBrE8

--HG--
extra : rebase_source : c169328d78c9c613f0d62bea8602e3619333d293

Code changes will land separately in github[1], and will be exported to
Firefox in a separate commit.

[1] https://github.com/mozilla-services/screenshots/pull/3711

MozReview-Commit-ID: 91sA1vqN1Il

--HG--
extra : rebase_source : af3409ab56d4d9a7470c748cc6a2ce89a6f63659

MozReview-Commit-ID: 6BEn52ARHQS

--HG--
extra : rebase_source : 8f3d66ae261036beeea9af5e5474a04a971c9f73
extra : source : 6abdc197ce71c269370ea120995125f039cb3474

client.mk hasn't been well-supported for years. Stop recommending it.

MozReview-Commit-ID: KWFhAQPIXWu

--HG--
extra : rebase_source : dafb307d82f1f0a3141d077102fd2fe21add65b4

As part of moving away from client.mk.

MozReview-Commit-ID: IMeM0k1tTsS

--HG--
extra : rebase_source : 2404f868300c4d40e9e154167654bbd596c3abe7

`mach configure` does the same thing as `make -f client.mk configure`.

While we're here, also change a `make` invocation to use `mach build`.

MozReview-Commit-ID: 4rgZN0dd0Jg

--HG--
extra : rebase_source : 7592814e56e896c299de7eacf4d126873629abfc

This should be functionally identical to `make -f client.mk`.

MozReview-Commit-ID: GfKHtezLBNL

--HG--
extra : rebase_source : e7965718b16d22055abdab2838e97cae63330ce9

The old code was simply running configure and manually invoking some
make targets via client.mk. These can both be done via `mach`.

As part of the change, the build targets have been consolidated. There
is still an abstraction leak here. But at least we aren't using client.mk.

MozReview-Commit-ID: 7oMXPWPZS6V

--HG--
extra : rebase_source : 6d632dc086d79a17e577da66336c77003d963f67

Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be

We need to get the offset across documents boundaries, since the scrollframe
might be inside a subdocument. In such cases we were previously computing
a (incorrect) zero offset for the scrollframe, which was throwing off the
margin for the sticky items inside the scrollframe.

MozReview-Commit-ID: AWeQ9ay2cmp

--HG--
extra : rebase_source : 7dd8eda26c482cc359042d79073740524efa792a

Bug 1413257: Allow disabling ffvpx's AVX2 support on linux64 for Thunderbird's buildbot; r=jya,rillian

MozReview-Commit-ID: 6USzO1GE7dJ

--HG--
extra : rebase_source : 936ee14b7a91470a9f9029b20748fbe6c8e55d15

MozReview-Commit-ID: FbAWplGGR1

--HG--
extra : rebase_source : dec3dbb87a79296e71146fdea839b76cf2c883ce

Bug 1393788 - Compress all JSDcov artifacts (.json files) into zip files after all tests are completed. r=gmierz,jmaher.

Building with "Linux x64 JSDCov", each suite of tests will produce a list of JSDCov artifacts (.json). This patch compresses all JSDCov artifacts into 1 zip file for each suite upon tests completion.
MozReview-Commit-ID: DaNLOQuW2lc

--HG--
extra : rebase_source : cceb912d0fe16f9921e1d13fe85d53af2abcb29c

MozReview-Commit-ID: EvtsPhiq6sd

--HG--
extra : rebase_source : 8c6fcb49f9373c9a3be2567111f935a3c9d4b7c7

Finding elements in the XHTML namespace will fail unless
element.isDOMElement is fixed so that it does not look at a
particular namespaceURI.

It is worth noting that, generally, the WPT element retrieval tests
are pretty awful and the new tests don't exactly match the style of
the preceding tests.  This intended, because the other tests are bad.
This should be addessed individually.

MozReview-Commit-ID: 8I3VwhJirSb

--HG--
extra : rebase_source : 2de08ec68dbf8b4768708bdb733965634ac4feda

If the node variable is an object that is not null, and nodeType is
not an own property of it, node.nodeType === node.ELEMENT_NODE might be
evaluated as undefined === undefined if ELEMENT_NODE is also missing.
This will pass the condition, which is an unintended consequence.

To remedy this, we first check that nodeType indeed exists on node
before proceding.

MozReview-Commit-ID: G0eaRvwm5mv

--HG--
extra : rebase_source : 8c08e0363f26095cf672d2b11699431b1fb4ef9f

This drops the now-superfluous element.isSVGElement.  SVG elements
are matched with element.isDOMElement because there is no special
need to distinguish them from other elements, apart from chrome elements.

MozReview-Commit-ID: 3AgEtyaAsPU

--HG--
extra : rebase_source : 7ec52aa9a7b7404eff5b6daf8ebe8259f06265da

This patch makes element.isDOMElement match any non-XUL element,
meaning it will henceforth match both SVG elements as well as any
custom XML namespaced element.

In the bug 1410796, Marionette does find the element, but is unable
to add it to the known web element store.  This is a result of the
changes made in bug 1400256, where I introduced a set of functions
for element type recognition needed for determining which web
element abstraction to use for an element.

We use element.isDOMElement to distinguish content elements from chrome
elements, and this change consequently makes element.isSVGElement
superfluous.

MozReview-Commit-ID: AkEHm6zroKz

--HG--
extra : rebase_source : c6f101e12839241f60c8c1b3908df3a3e4a89a51

Bug 1413332 - Make geckoview's BuildConfig under --with-gradle include computed values. r=maliu,snorp

There's already a secret dependency where
mobile/android/base/Makefile.in (and generated AppConstants.java)
depends on $topobjdir/buildid.h, so this shouldn't be much worse than
what we have.

MozReview-Commit-ID: 2hkAGE9uT10

--HG--
extra : rebase_source : 090b7a5f2063a4e0cc20252703e6575e6716448a

Bug 1412611 Reorder member initialization to fix -Wreorder warning in widget/windows/nsLookAndFeel.cpp r=njn

MozReview-Commit-ID: EJp1FqllORN

--HG--
extra : rebase_source : f7c8983f3ae7e1aae1a14fd7321ab1aae8b7ba04

MozReview-Commit-ID: D9Bq3NZYaO6

In the future, GeckoAppShell will only be part of the service process
library, and will not be part of the app process library. Therefore, we
should minimize GeckoAppShell usage in any GeckoView code that will
likely end up in the app process library.

In particular, AndroidGamepadManager and Clipboard are made to accept
Context as arguments, instead of using
GeckoAppShell.getApplicationContext() for getting the Context.

MozReview-Commit-ID: G9SC815H5Ku

Move the "Bookmark:Insert" and "Image:SetAs" events from GeckoApp to
GeckoApplication. These events are global to the application, and they
operate on the background thread, which will no longer be an option for
the GeckoView event dispatcher.

MozReview-Commit-ID: 8kesv8sJ8At

Remove support for a default prompt delegate in GeckoView. Instead, all
prompts without a known window will go to the active GeckoView if
available.

MozReview-Commit-ID: C62V6jtgDCl

Move GeckoAccessibility out of gecko-view and into gecko-browser.
GeckoAccessibility as-is is currently only good for Fennec and is not
suitable for generic GeckoView use.

MozReview-Commit-ID: Fek8fLJNC6F

--HG--
rename : mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAccessibility.java => mobile/android/base/java/org/mozilla/gecko/GeckoAccessibility.java
rename : mobile/android/geckoview/src/thirdparty/java/com/googlecode/eyesfree/braille/selfbraille/ISelfBrailleService.java => mobile/android/thirdparty/com/googlecode/eyesfree/braille/selfbraille/ISelfBrailleService.java
rename : mobile/android/geckoview/src/thirdparty/java/com/googlecode/eyesfree/braille/selfbraille/SelfBrailleClient.java => mobile/android/thirdparty/com/googlecode/eyesfree/braille/selfbraille/SelfBrailleClient.java
rename : mobile/android/geckoview/src/thirdparty/java/com/googlecode/eyesfree/braille/selfbraille/WriteData.java => mobile/android/thirdparty/com/googlecode/eyesfree/braille/selfbraille/WriteData.java

Handle the negate_wheel_scroll pref in native code so we don't depend on
PrefsHelper in NativePanZoomController.

MozReview-Commit-ID: 14YCcrDlObz

Remove the native GeckoView loadUri call because it's Fennec-only.
Replace the call with a Fennec-only "Tab:OpenUri" event.

MozReview-Commit-ID: 7xZW9aceoPL

Make GeckoViewSettings implement Parcelable so we can serialize it to
save settings.

MozReview-Commit-ID: HoxqbewtJko

Implement Parcelable interface for GeckoBundle so it can be marshalled
across processes over Bundle, AIDL, etc. Also, add a stub for a
`GeckoBundle.put` method that suggests alternatives to use.

MozReview-Commit-ID: IArNL7LYUPZ

Removing the previous cpp files moved AndroidBridge.cpp to a different
compilation unit, and that caused some problems with other code that
depended on AndroidBridge being in or not in their compilation unit.
This patch fixes those (unwanted) dependencies.

MozReview-Commit-ID: DJsk3iENsx2

Remove AndroidJNI.cpp, which is empty. Also remove some JNI string
functions that are unused from AndroidBridge.

MozReview-Commit-ID: CsP4L0TyN48

Remove AndroidJavaWrappers. Convert nsJNIString usages to use
jni::String and AndroidMotionEvent usages to use java::sdk::MotionEvent.
Move key code constants to GeckoEditableSupport.cpp.

MozReview-Commit-ID: CwcGGADWCNv

Remove AndroidJNIWrapper. It was primarily used by JNI.jsm and WebRTC.
Usages in WebRTC are replaced with equivalent uses of JNI templates.

MozReview-Commit-ID: DPSeMOtH2wF