Skip to content
Snippets Groups Projects
  1. Jun 29, 2023
  2. Jun 22, 2023
    • Mike Hommey's avatar
      Bug 1839263 - Don't derive assertRaisesFromLine from assertRaises.... · dfa753e4
      Mike Hommey authored
      Bug 1839263 - Don't derive assertRaisesFromLine from assertRaises. r=firefox-build-system-reviewers,ahochheiden, a=test-only DONTBUILD
      
      In python 3.11 (maybe also 3.10, I haven't tested that version ; 3.9 was
      definitely different), by the time the context manager comes back in our
      assertRaisesFromLine, the traceback is not available anymore (or yet,
      I'm not entirely sure which way it does) to inspect and check the line
      numbers we want to check.
      
      And while assertRaises exposes the thrown exception in its `exception`
      attribute, it also resets the traceback associated with it, so we can't
      find it there either.
      
      So instead, we implement our own context manager for
      assertRaisesFromLine such that we can access that traceback.
      
      Differential Revision: https://phabricator.services.mozilla.com/D181425
      dfa753e4
    • Mike Hommey's avatar
      Bug 1839263 - Fix python configure lint on python >= 3.10.... · 0f09a132
      Mike Hommey authored
      Bug 1839263 - Fix python configure lint on python >= 3.10. r=firefox-build-system-reviewers,ahochheiden,sergesanspaille, a=test-only DONTBUILD
      
      Python 3.10 added some more arguments to the CodeTypes constructor. It
      also changed co_lnotab to co_linetables.
      
      We were using co_lnotab to simulate a function with a def at a specific
      line and a raise at a specific other line. I'm not sure how I ended up
      with this particular requirement (this may have been related to python 2
      still being used back then), but as of now, it doesn't seem we need the
      def to be at a specific location, so we can avoid needing to generate
      a co_linetables/co_lnotab, relying instead on the raise expression being
      on the co_firstlineno+1 in the thrower function.
      
      As for the extra arguments, it turns out python 3.8 also introduced a
      CodeType.replace method that can be used to derive a CodeType object
      from another, which is certainly simpler than calling its construtor
      with the right set of arguments.
      
      Differential Revision: https://phabricator.services.mozilla.com/D181424
      0f09a132
  3. Apr 02, 2024
  4. Apr 01, 2024
  5. Mar 30, 2024
  6. Apr 01, 2024
  7. Mar 07, 2024
  8. Mar 30, 2024
    • Ryan VanderMeulen's avatar
      Bug 1881416 - Relax expectations for... · 9f87b3b2
      Ryan VanderMeulen authored
      Bug 1881416 - Relax expectations for /secure-payment-confirmation/enrollment.https.html to allow timeouts on all platforms. a=test-only
      
      This isn't a feature we support anyway, so let's not make things harder
      than they need to be.
      9f87b3b2
  9. Mar 29, 2024
  10. Mar 26, 2024
  11. Mar 28, 2024
  12. Mar 30, 2024
  13. Mar 28, 2024
  14. Mar 26, 2024
  15. Mar 15, 2024
  16. Mar 25, 2024
  17. Mar 15, 2024
  18. Mar 13, 2024
  19. Mar 22, 2024
  20. Mar 21, 2024
  21. Mar 11, 2024
  22. Mar 16, 2024
  23. Mar 21, 2024
  24. Mar 22, 2024
  25. Mar 21, 2024
  26. Mar 19, 2024
Loading