Skip to content
Snippets Groups Projects
  1. Oct 27, 2017
  2. Oct 26, 2017
    • Nick Alexander's avatar
      Bug 1249421 - Include stub AndroidManifest.xml. r=maliu · 5b055513
      Nick Alexander authored
      This should avoid Bug 1249421, but it will also address an
      Android-Gradle plugin 3.0 issue, where the plugin requires the
      manifest at Gradle configuration time.  Currently we don't provide it
      until Gradle evaluation time, leading to this error, and to the plugin
      failing.
      
      MozReview-Commit-ID: 4NkiQSooLly
      
      --HG--
      extra : rebase_source : 21b11e8cb4ff990df3adf18718ec3bda869486a0
      5b055513
    • Andrew McCreight's avatar
      Bug 1412138 - Re-fix mode lines in ipc/chromium and ipc/glue. r=kanru · 2f7ae795
      Andrew McCreight authored
      --HG--
      extra : rebase_source : 0f12dc7af00745cf83a93b1faa516f51ff293cc2
      2f7ae795
    • Nick Alexander's avatar
      Bug 1411667 - Remove Spoon plugin references entirely. r=maliu · d86b10b8
      Nick Alexander authored
      Spoon and some Gradle work allowed to run certain JUnit 3 test suites
      locally.  At the time, running the various test suites was diffficult.
      Fast forward, and it's easier to run these suites, and in general they
      are only run in Android Studio.  This will only get better as we move
      the background services tests into a separate module (Bug 1229149).
      
      MozReview-Commit-ID: KZTWmkhwi96
      
      --HG--
      extra : rebase_source : 5244e81ffe81e8611034fea1edb07681266a7581
      d86b10b8
  3. Oct 19, 2017
    • Nick Alexander's avatar
      Bug 1411686 - Part 2: Don't invoke |make gradle-targets| for AB_CD=multi. r=maliu · d5291625
      Nick Alexander authored
      This work-around isn't needed for the moz.build system because there's
      no equivalent of the
      
      |mach build| > |mach gradle| > |make gradle-targets|
      
      dependency chain that "re-enters" Make processing.  That is, the
      nodeps mechanism ensures that nothing in m/a/b/Makefile.in (that knows
      about AB_CD) ever sees AB_CD=multi.
      
      MozReview-Commit-ID: qZKAtlLhJw
      
      --HG--
      extra : rebase_source : b9dd2f4f4dd8af5c4d594927226c7b8230723b9f
      extra : source : c965d3adbcbf35f417dbf0832b44de6c52b89535
      d5291625
    • Nick Alexander's avatar
      Bug 1411686 - Part 1: Force Gradle to run during |mach package|. r=maliu · 6d97cb22
      Nick Alexander authored
      It looks like I didn't handle this flow -- which only matters during
      l10n multi-locale builds and l10n single-locale repacks -- during the
      initial Gradle landing.  Now we need to handle it.
      
      Remember that the l10n process runs |mach build && mach package|, and
      then modifies the object directory by inserting new localized resource
      files.  It then runs |mach package| again and expects to regenerate
      the ap_ file, ready to splice it into the existing apk file.  The
      existing code just copied the .ap_ built by Gradle without
      regenerating the ap_ file.  This commit forces running Gradle again,
      which will pick up the new resources in the object directory.
      
      The chain of dependencies is:
      
      |mach package| > gecko-nodeps.ap_ > .aapt.nodeps > .gradle.deps
      
      and the latter two targets are FORCE, so they always get run
      (regardless of the freshness of the inputs).
      
      In fact, this runs the entire Gradle process again, including
      producing classes.dex.  (The moz.build process doesn't compile the
      Java source code again.)  This patch changes the existing behaviour to
      copy the regenerated classes.dex into the repacked apk and avoid the
      need for the R.java IDs to line up across the |mach build| and |mach
      package| invocations.  This turned out to be necessary to support
      multi-locale builds with newer Gradle versions, which don't appear to
      preserve aapt R.java IDs across the
      
      |mach build|, |mach package|, |mach compare-locales|, |mach package|
      
      chain.
      
      MozReview-Commit-ID: FlhtQPwR5xG
      
      --HG--
      extra : rebase_source : ee00d5507a63b47b253cb0e310d2fa9a815442a1
      extra : source : 3a6e8fedc00a5c2930e0f2bc3077cd9beed5c5d2
      6d97cb22
  4. Oct 23, 2017
    • Nick Alexander's avatar
      Bug 1411686 - Pre: Fix JNI wrapper dependencies. r=maliu · 91774829
      Nick Alexander authored
      When built as part of a consuming application, a library's bundle*
      target is called but not its assemble* target.  (When built by itself
      for distribution, a library's assemble* target is called.)  This
      corrects the wrapper dependencies.
      
      MozReview-Commit-ID: 9ooHMNPK2U4
      
      --HG--
      extra : rebase_source : 0b9d979a0066eda86ec39e9700a2e11e8073cea6
      91774829
  5. Oct 28, 2017
  6. Oct 26, 2017
  7. Oct 27, 2017
  8. Oct 25, 2017
    • Andreas Tolfsen's avatar
      Bug 1411281 - Make assert_same_element accept webdriver.Element r=jgraham · 2529547a
      Andreas Tolfsen authored
      Allow assert_same_element to compare web element references (JSON
      Objects) with webdriver.Element and vice versa.
      
      Tests will typically look up some element using traditional means
      and use that as the trusted comparison when retrieving the same
      element using the session.transport.send primitive that returns
      the plain JSON Object.
      
      MozReview-Commit-ID: 2DScnviOevb
      
      --HG--
      extra : rebase_source : d84fc331cdf2b2eb2bd36b71a184e5239b60bdff
      2529547a
    • Andreas Tolfsen's avatar
      Bug 1411281 - Unmarshal all responses in WPT WebDriver client r=jgraham · d8489ee7
      Andreas Tolfsen authored
      The WPT WebDriver client currently only unmarshals responses for some
      commands (notably execute_script, execute_async_script, and find.css).
      For the client API we want to unmarshal all response bodies automatically.
      
      This patch moves all JSON serialisation/deserialisation to a new
      webdriver.protocol package so that it is not scattered around
      the client API.  It introduces specialisations of JSONEncoder and
      JSONDecoder that allows web element references to be recognised
      and converted to complex webdriver.Element objects.
      
      This change means it is no longer necessary for callers to invoke
      webdriver.Session._element to convert the response to a web element
      as this will be done automatically on any request- and response
      body to webdriver.Sesson.send_command.
      
      An important thing to note is that HTTPWireProtocol.send does not  follow
      this behaviour by default.  That is because session.transport.send
      is used throughout WebDriver tests in WPT as a way to get the raw
      JSON body without having to set up session state manually.
      
      MozReview-Commit-ID: 5UyDAe43Hgf
      
      --HG--
      extra : rebase_source : b86495dd0dcd102e6dea87011caafad475b88723
      d8489ee7
    • Andreas Tolfsen's avatar
      Bug 1411281 - Swap webdriver.Element ctor arguments r=jgraham · ca6428c4
      Andreas Tolfsen authored
      It is more natural for the web element UUID to come first, followed
      by the associated session state.
      
      The patch also adds ctor documentation.
      
      MozReview-Commit-ID: 5iV4SZzMeKS
      
      --HG--
      extra : rebase_source : e9f68a2a934b2c13a9d1d913204e7e3d9bce6b42
      ca6428c4
    • Andreas Tolfsen's avatar
      Bug 1411281 - Add equality test for webdriver.Element r=jgraham · ffe20afd
      Andreas Tolfsen authored
      When comparing two instances of webdriver.Element we want to first
      check the type, to make sure the "id" attribute is present, then
      compare the web element reference UUIDs.  These are supposed to be
      unique across all browsing contexts.
      
      MozReview-Commit-ID: 68PUBQxPdQ5
      
      --HG--
      extra : rebase_source : f0c52efd0db3a13ea1b90dc6c058ebee2de76e1d
      ffe20afd
  9. Oct 26, 2017
    • Andreas Tolfsen's avatar
      Bug 1411281 - Add equality test for webdriver.Session r=jgraham · b0cfd277
      Andreas Tolfsen authored
      When comparing two instances of webdriver.Session we want to first
      check that there is a current session, then the type of the object
      to compare with to make sure the "session_id" attribute is present,
      then finally we compare the session IDs.
      
      MozReview-Commit-ID: 6Ch4Uy2MEhB
      
      --HG--
      extra : rebase_source : 252fe31680c57831b122d2bb53fe133b32c322eb
      b0cfd277
  10. Oct 25, 2017
  11. Oct 28, 2017
  12. Oct 26, 2017
  13. Oct 27, 2017
    • Daniel Holbert's avatar
      Bug 1412427 part 8: (automated patch) Switch a bunch of C++ files in gfx to... · 126bd9e1
      Daniel Holbert authored
      Bug 1412427 part 8: (automated patch) Switch a bunch of C++ files in gfx to use our standard mode lines. r=jrmuizel
      
      This patch was generated automatically by the "modeline.py" script, available
      here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
      
      For every file that is modified in this patch, the changes are as follows:
       (1) The patch changes the file to use the exact C++ mode lines from the
           Mozilla coding style guide, available here:
      https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
      
       (2) The patch deletes any blank lines between the mode line & the MPL
           boilerplate comment.
      
       (3) If the file previously had the mode lines and MPL boilerplate in a
           single contiguous C++ comment, then the patch splits them into
           separate C++ comments, to match the boilerplate in the coding style.
      
      MozReview-Commit-ID: 77D61xpSmIl
      
      --HG--
      extra : rebase_source : c6162fa3cf539a07177a19838324bf368faa162b
      126bd9e1
    • Daniel Holbert's avatar
      Bug 1412427 part 7: Manually fix up a few non-standard quirks in mode lines &... · de4b2b1c
      Daniel Holbert authored
      Bug 1412427 part 7: Manually fix up a few non-standard quirks in mode lines & MPL text, in gfx source files. r=jrmuizel
      
      MozReview-Commit-ID: JgK3UhG20kn
      
      --HG--
      extra : rebase_source : 2677c73948463f84eeafc4895697dbdcd5fccae4
      de4b2b1c
    • Daniel Holbert's avatar
      Bug 1412427 part 6: Remove stray "//" prefix before first line of MPL... · 3b352c72
      Daniel Holbert authored
      Bug 1412427 part 6: Remove stray "//" prefix before first line of MPL boilerplate comment, in some gfx source files. r=jrmuizel
      
      This patch was automatically generated. I found the files to be fixed in this
      patch with the following command:
      grep -r "//  \* This Source Code" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ####
      old="//  \* This Source Code Form is subject to the terms of the Mozilla Public"
      new=" \* This Source Code Form is subject to the terms of the Mozilla Public"
      sed -i s%"^$old"%"$new"% $1
      ####
      
      MozReview-Commit-ID: Ihx0EAOkT2g
      
      --HG--
      extra : rebase_source : 4dc97f234495e3ec1f4904e91d43d00fd3810626
      3b352c72
    • Daniel Holbert's avatar
      Bug 1412427 part 5: Deindent over-indented MPL boilerplate comments down to 1... · fc539779
      Daniel Holbert authored
      Bug 1412427 part 5: Deindent over-indented MPL boilerplate comments down to 1 space, for consistency & alignment. (whitespace-only) r=jrmuizel
      
      This patch was automatically generated. I found the files to be fixed in this
      patch with the following command:
      grep -r "  \* This Source Code" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ###
      line1=" \* This Source Code Form is subject to the terms of the Mozilla Public"
      line2=" \* License, v\. 2\.0\. If a copy of the MPL was not distributed with this"
      line3=" \* file, You can obtain one at http://mozilla\.org/MPL/2\.0/\. \*/"
      
      # Strip off 1 space at beginning:
      sed -i s%"^ $line1"%"$line1"% $1
      sed -i s%"^ $line2"%"$line2"% $1
      sed -i s%"^ $line3"%"$line3"% $1
      ###
      
      MozReview-Commit-ID: EwCjyajgY4W
      
      --HG--
      extra : rebase_source : c61ca17ba556290d1f27af0a0c84e2ccc5371a36
      fc539779
    • Daniel Holbert's avatar
      Bug 1412427 part 4: Indent under-indented MPL boilerplate comments by 1 space,... · ecf5ee68
      Daniel Holbert authored
      Bug 1412427 part 4: Indent under-indented MPL boilerplate comments by 1 space, for consistency & alignment. (whitespace-only) r=jrmuizel
      
      This patch was automatically generated. I found the files to be fixed in this
      patch with the following command:
      grep -r "^\* This Source Code" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ###
      line1="\* This Source Code Form is subject to the terms of the Mozilla Public"
      line2="\* License, v\. 2\.0\. If a copy of the MPL was not distributed with this"
      line3="\* file, You can obtain one at http://mozilla\.org/MPL/2\.0/\. \*/"
      
      # Insert 1 space at beginning:
      sed -i s%"^$line1"%" $line1"% $1
      sed -i s%"^$line2"%" $line2"% $1
      sed -i s%"^$line3"%" $line3"% $1
      ###
      
      MozReview-Commit-ID: HXBMrfnhlVr
      
      --HG--
      extra : rebase_source : de4c78563711f8366e2978c5199a5041875fbe38
      ecf5ee68
    • Daniel Holbert's avatar
      Bug 1412427 part 3: Replace 10 gfx usages of a particular non-standard emacs... · 76d8e6a7
      Daniel Holbert authored
      Bug 1412427 part 3: Replace 10 gfx usages of a particular non-standard emacs mode line with our standard mode line. r=jrmuizel
      
      This patch was mostly[1] automatically generated. I found the files to be fixed
      in this patch with the following command:
      grep -r "C++; indent-tabs-mode:" gfx
      
      ...and then I modified each of these files with the following script
      (where $1 is the filename to be modified):
      ###
      old="/\* -\*- Mode: C++; indent-tabs-mode: nil; c-basic-offset: 4 -\*- \*/"
      new="/\* -\*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -\*- \*/"
      
      sed -i s%"^$old"%"$new"% $1
      ###
      
      [1] NOTE: Nearly all of these files use 2-space indentation, so it's correct
      (from a consistency perspective and a reflecting-reality perspective) that
      we're reducing their "c-basic-offset: 4" down to "c-basic-offset: 2" here.  The
      one exception is nsDeviceContext.h, which *does* actually use 4-space
      indentation right now -- so I'm leaving that file with "c-basic-offset: 4" in
      its mode line.  This manual change (reverting 1 character from the automated
      process) is the only piece of this patch that isn't automated.
      
      MozReview-Commit-ID: L4MbyeYSbfY
      
      --HG--
      extra : rebase_source : 8ddbe422471bfd8b0060e96fb1c8cd062f10f290
      76d8e6a7
    • Daniel Holbert's avatar
      Bug 1412427 part 2: Move vim mode line below emacs mode line in a few gfx... · 0aa7ac89
      Daniel Holbert authored
      Bug 1412427 part 2: Move vim mode line below emacs mode line in a few gfx files, for consistency. r=jrmuizel
      
      This patch doesn't modify the mode lines at all -- it just swaps their order,
      and makes each one its own C++ comment, separate from the MPL boilerplate
      comment.
      
      MozReview-Commit-ID: BEZJVj2sMuK
      
      --HG--
      extra : rebase_source : 9e0946c8a8d0b67c11b5932b9d1e51e0e6e8ebef
      0aa7ac89
    • Daniel Holbert's avatar
      Bug 1412427 part 1: Add standard mode line & MPL boilerplate to a few gfx C++... · 976e9f7e
      Daniel Holbert authored
      Bug 1412427 part 1: Add standard mode line & MPL boilerplate to a few gfx C++ files that are missing it entirely. r=jrmuizel
      
      I copied the boilerplate comment directly from the Coding Style MDN page:
      https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
      
      MozReview-Commit-ID: 8rO6SfBIaRl
      
      --HG--
      extra : rebase_source : 90093621cbaa2a62b19e22b0eacad600fc586560
      976e9f7e
  14. Oct 30, 2017
  15. Oct 27, 2017
  16. Oct 26, 2017
  17. Oct 30, 2017
Loading